Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #38 +/- ##
=======================================
Coverage 84.89% 84.89%
=======================================
Files 40 40
Lines 2290 2290
Branches 293 293
=======================================
Hits 1944 1944
Misses 261 261
Partials 85 85 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
Code reviewNo issues found. Checked for bugs and AGENTS.md compliance. |
why: Tool titles are display fields visible in Claude Code's tool catalog UI and `claude mcp list`-style outputs. "List Windows" competes with browser/editor/WM MCPs that share the noun; "List tmux Windows" is unambiguous. Title is NOT in the BM25 corpus (verified vs fastmcp _extract_searchable_text at server/transforms/search/base.py:41-57) — this lever is purely display-time disambiguation, which still pays off in human-readable tool catalogs even though it has no impact on ToolSearch ranking. Verbs-of-art (Send Keys, Pipe Pane, Snapshot Pane, Capture Pane, Paste Text, Select Pane, etc.) are tmux-specific terms already and stay generic — over-prefixing reads as visual chrome. what: - 31 title edits across 8 tool modules (server, session, window, option, env, hook, buffer, wait-for-channel families). Hierarchy nouns (window, session, server, option, environment, hook, buffer, channel) gain "tmux" qualifier; verbs-of-art carved out - Parametrized title-audit tests for both the require-tmux set (31 tools) and the verb-of-art set (19 tools); the negative test catches accidental over-prefixing in a future change
tony
force-pushed
the
feature/tmux-title-tagging
branch
from
9cef5b3 to
ee28666
Compare
Member
Author
Code reviewNo issues found. Re-checked the latest delta for bugs and AGENTS.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
31 hierarchy-noun tool titles gain a
tmuxqualifier (e.g. "List Sessions" → "List tmux Sessions") for display-time disambiguation in tool catalog UIs andclaude mcp list-style outputs.Verbs-of-art (
Send Keys,Pipe Pane,Snapshot Pane,Capture Pane,Paste Text) stay generic — the verb is already a tmux-specific term and over-prefixing reads as visual chrome.Pure display-time lever — title is not in BM25's search corpus (verified vs FastMCP's
_extract_searchable_text), so this won't shift activation behavior. It just makes the catalog readable when a user has multiple MCPs sharing the noun.Test plan
uv run ruff check . --fix && uv run ruff format .uv run mypyuv run py.test --reruns 0 -vvv(430 passed; +2 title-audit tests)just build-docs