Conversation
rjrelyea
approved these changes
Mar 7, 2025
rjrelyea
left a comment
There was a problem hiding this comment.
I have a suggestion, which you can add before merge or ignore.
| # data with context-specific tag class | ||
| cls.data_context_specific = b"\x86\x02\x0a\x0b" | ||
| # data with private tag class | ||
| cls.data_private = b"\xc6\x02\x0a\x0b" |
There was a problem hiding this comment.
We probably should have a test for length > 128 to make sure the llen encoding/decoding is happening correctly
Member
Author
There was a problem hiding this comment.
this is reusing common code for encoding and decoding length, so I'm quite sure that it will handle it correctly
we have test coverage for it here:
python-ecdsa/src/ecdsa/test_der.py
Lines 90 to 125 in 55d2b56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While not needed for ECDSA/ECDH PKCS#8 files, it looks like it will be necessary for the PQC algorithms, so provide that too, so we can do some code reuse.