patch ahash 0.7.x to diable stdsimd in unsupported nightlies #201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@tkaitchuck Could you make a patch release for the 0.7 branch to fix #200? |
chriscerie
approved these changes
Feb 7, 2024
njelich
approved these changes
Feb 8, 2024
tkaitchuck
approved these changes
Feb 10, 2024
This was referenced Feb 11, 2024
ivoanjo
added a commit
to DataDog/libdatadog
that referenced
this pull request
Feb 12, 2024
**What does this PR do?** This commit updates the `ahash` dependency to version 0.7.8. **Motivation:** This version includes tkaitchuck/aHash#201 which fixes miri in CI (and in general any stuff that runs with rust nightly). **Additional Notes:** N/A **How to test the change?** Validate that CI is still green.
2 tasks
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this pull request
Feb 27, 2024
This crate has a build error relating to the `stdsimd` feature use. This has been fixed in newer versions of the crate, however on the one checked out in the repo, this is still an issue. This change fixes this issue by importing the fix[1] provided by the authors. [1] tkaitchuck/aHash#201
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this pull request
Feb 29, 2024
This crate has a build error relating to the `stdsimd` feature use. This has been fixed in newer versions of the crate, however on the one checked out in the repo, this is still an issue. This change fixes this issue by importing the fix[1] provided by the authors. [1] tkaitchuck/aHash#201
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this pull request
Mar 1, 2024
This crate has a build error relating to the `stdsimd` feature use. This has been fixed in newer versions of the crate, however on the one checked out in the repo, this is still an issue. This change fixes this issue by importing the fix[1] provided by the authors. [1] tkaitchuck/aHash#201
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this pull request
Mar 5, 2024
This crate has a build error relating to the `stdsimd` feature use. This has been fixed in newer versions of the crate, however on the one checked out in the repo, this is still an issue. This change fixes this issue by importing the fix[1] provided by the authors. [1] tkaitchuck/aHash#201
emerick
pushed a commit
to brave/brave-core
that referenced
this pull request
Mar 8, 2024
This crate has a build error relating to the `stdsimd` feature use. This has been fixed in newer versions of the crate, however on the one checked out in the repo, this is still an issue. This change fixes this issue by importing the fix[1] provided by the authors. [1] tkaitchuck/aHash#201
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This keeps the stdsimd feature working for older nightlies, so there shouldn't be any loss of functionality.