DOC-3131: It wasn't possible to add comments to selected footnotes elements.#3662
Merged
kemister85 merged 6 commits intofeature/7.8.0/DOC-3131from Apr 9, 2025
Merged
Conversation
kemister85
added
the
upcoming release
kemister85
requested review from
a team,
abhinavgandham and
soritaheng
as code owners
kemister85
requested review from
EkimChau,
MitchC1999 and
ShiridiGandham
and removed request for
a team
…not possible if the files had the correct extension but an incorrect MIME type.
…der was not possible if the files had the correct extension but an incorrect MIME type." This reverts commit b6a1bd0.
kimwoodfield
approved these changes
Apr 8, 2025
ltrouton
approved these changes
Apr 8, 2025
Contributor
ltrouton
left a comment
ltrouton
left a comment
There was a problem hiding this comment.
Should we make it clearer we are referring to the footnotes plugin?
Co-authored-by: ltrouton <46954949+ltrouton@users.noreply.github.com>
Co-authored-by: ltrouton <46954949+ltrouton@users.noreply.github.com>
tiny-ben-tran
approved these changes
Apr 9, 2025
Contributor
Author
Not sure, as we are only enabling footnotes as an annotatable element see: |
kemister85
commented
Apr 9, 2025
kemister85
added a commit
that referenced
this pull request
Apr 9, 2025
#3660) * DOC-3131: Initial commit for TinyMCE 7.8.0 release notes. * DOC-3131: A confirmation dialog now appears when resolving conversation to match the UX of deleting a conversation. (#3671) * DOC-3131: Setting editor height to a pt or em value was ignoring min/max height settings. (#3669) * DOC-3131: The `editor.selection.scrollIntoView()` method now pads the target scroll area with a small margin, ensuring content doesn't sit at the very edge of the viewport. (#3666) * DOC-3131: The editor.selection.scrollIntoView() method now pads the target scroll area with a small margin, ensuring content doesn't sit at the very edge of the viewport. * Update modules/ROOT/pages/7.8.0-release-notes.adoc Co-authored-by: Arvin(Jintao) Han <20640097+ArvinJ-H@users.noreply.github.com> --------- Co-authored-by: Arvin(Jintao) Han <20640097+ArvinJ-H@users.noreply.github.com> * DOC-3131: The change event was not dispatched when deleting a comment reply. (#3670) * DOC-3131: Focus outline was misaligned with comment card border on saving an edit. (#3678) * DOC-3131: Source Code editor was not scrolling to the editor's caret position in Firefox. (#3667) * DOC-3131: Source Code editor was not scrolling to the editor's caret position in Firefox. * Update modules/ROOT/pages/7.8.0-release-notes.adoc Co-authored-by: Karl Kemister-Sheppard <karlkemistersheppard@gmail.com> * Update modules/ROOT/pages/7.8.0-release-notes.adoc Co-authored-by: Karl Kemister-Sheppard <karlkemistersheppard@gmail.com> --------- Co-authored-by: Karl Kemister-Sheppard <karlkemistersheppard@gmail.com> * DOC-11923: Add note on handling of relative URLs with base_url configuration option. (#3682) * DOC-11923: Add note on handling of relative URLs with base_url configuration option. * DOC-3131: add content. * DOC-3131: update title headers. * DOC-3189: Add new options for preserving MathML elements and attributes in the Math plugin (#3681) * DOC-3189: Add new options for preserving MathML elements and attributes in the Math plugin. * Update modules/ROOT/pages/7.8.0-release-notes.adoc * Update modules/ROOT/pages/7.8.0-release-notes.adoc * Update modules/ROOT/pages/7.8.0-release-notes.adoc * Update modules/ROOT/pages/7.8.0-release-notes.adoc * DOC-3161: Add new `tinycomments_fetch_author_info` option and refactored callback demo. (#3675) * DOC-3189: Update comments callback demo DOC-3189: Added tinycomments_fetch_author_info new option Removes Pollyjs from old demo added release notes for TinyMCE 7.8.0 * DOC-3190: Clarify author identification process in comments callback documentation. * Update modules/ROOT/pages/7.8.0-release-notes.adoc Co-authored-by: Hamza Benkhaldoun <hamza0867@gmail.com> * Update modules/ROOT/partials/configuration/tinycomments_fetch_author_info.adoc * Update modules/ROOT/partials/configuration/tinycomments_fetch_author_info.adoc * DOC-3161: Update tinycomments_fetch_author_info documentation to indicate optional fields for authorName and authorAvatar. * Update modules/ROOT/partials/configuration/tinycomments_fetch_author_info.adoc * DOC-3161: Fixed demo * DOC-3161: Updated mentions demo * DOC-3161: fix issue * DOC-3161: Update new option * Potential fix for code scanning alert no. 40: Semicolon insertion Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> * Potential fix for code scanning alert no. 39: Semicolon insertion Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> --------- Co-authored-by: Hamza Benkhaldoun <hamza0867@gmail.com> Co-authored-by: MitchCTiny <mitchell.crompton@tiny.cloud> Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> * DOC-3189: Refactor promotion documentation and update references to new promotions page (#3674) * DOC-3189: Refactor promotion documentation and update references to new promotions page. * DOC-3190: Update promotion documentation to clarify options for open source and cloud versions. * Update modules/ROOT/partials/configuration/onboarding.adoc * Update modules/ROOT/partials/configuration/promotion.adoc * DOC-3131: Fix sidebar nesting issue. * DOC-3131: Keyboard navigation between toolbars no longer loses focus. (#3661) * DOC-3131: Keyboard navigation between toolbars no longer loses focus. * Update modules/ROOT/pages/7.8.0-release-notes.adoc Co-authored-by: CODE:AG <57781325+abhinavgandham@users.noreply.github.com> --------- Co-authored-by: CODE:AG <57781325+abhinavgandham@users.noreply.github.com> * DOC-3131: New subtoolbar support for context toolbars. (#3664) * DOC-3131: Add image filter assets, and new `uploadcare_filters` option for `uploadcare` plugin. (#3679) * DOC-3131: Add image filter assets, and new uploadcare_filters option for Uploadcare plugin. * DOC-3131: update live-demo with new uploadcare_filters option. * DOC-3189: Enhance documentation for uploadcare_filters option in Image Optimizer plugin. * DOC-3131: Copy edits to filter list name. * DOC-3131: Add auto-image-enhancement icon and update documentation, remove old image-enhancements.svg and ref. * DOC-3131: Fix note missing border. * Update antora.yml * DOC-3131: Non-uploadcare image URLs would be altered by color adjustments even when they failed to upload. (#3665) * DOC-3131: Dragging and dropping image files onto the placeholder was not possible if the files had the correct extension but an incorrect MIME type. (#3663) * DOC-3131: Dragging and dropping image files onto the placeholder was not possible if the files had the correct extension but an incorrect MIME type. * Update modules/ROOT/pages/7.8.0-release-notes.adoc * Update modules/ROOT/pages/7.8.0-release-notes.adoc * DOC-3131: Placeholder element is now responsive and adjust to container width. (#3683) Co-authored-by: Karl Kemister-Sheppard <karlkemistersheppard@gmail.com> * DOC-3131: Add changelog. * DOC-3131: It wasn't possible to add comments to selected footnotes elements. (#3662) * DOC-3131: It wasn't possible to add comments to selected footnotes elements. * DOC-3131: Dragging and dropping image files onto the placeholder was not possible if the files had the correct extension but an incorrect MIME type. * Revert "DOC-3131: Dragging and dropping image files onto the placeholder was not possible if the files had the correct extension but an incorrect MIME type." This reverts commit b6a1bd0. * Update modules/ROOT/pages/7.8.0-release-notes.adoc Co-authored-by: ltrouton <46954949+ltrouton@users.noreply.github.com> * Update modules/ROOT/pages/7.8.0-release-notes.adoc Co-authored-by: ltrouton <46954949+ltrouton@users.noreply.github.com> * Update modules/ROOT/pages/7.8.0-release-notes.adoc --------- Co-authored-by: ltrouton <46954949+ltrouton@users.noreply.github.com> * DOC-3131: The tooltip for the `blockquote` button was not translated in Hebrew. (#3684) * DOC-3131: The tooltip for the button was not translated in Hebrew. * DOC-3131: Updated translation entry in 7.7.0 docs under known issues to point to this bug fix entry. --------- Co-authored-by: Karl Kemister-Sheppard <karlkemistersheppard@gmail.com> * DOC-3131: copy edits, release note re-structure and final version checks. * DOC-3131: add missed new line space. * DOC-3131: api-version bump for TinyMCE 7.8.0. * DOC-3131: update productminorversion to 7.8. --------- Co-authored-by: Arvin(Jintao) Han <20640097+ArvinJ-H@users.noreply.github.com> Co-authored-by: CODE:AG <57781325+abhinavgandham@users.noreply.github.com> Co-authored-by: Hamza Benkhaldoun <hamza0867@gmail.com> Co-authored-by: MitchCTiny <mitchell.crompton@tiny.cloud> Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Co-authored-by: ltrouton <46954949+ltrouton@users.noreply.github.com>
kemister85
added a commit
that referenced
this pull request
Apr 9, 2025
* DOC-3178: TinyMCE 7.8.0 Release Documentation. * DOC-3131: TinyMCE 7.8.0 Release Documentation and Community Changelog. (#3660) * DOC-3131: Initial commit for TinyMCE 7.8.0 release notes. * DOC-3131: A confirmation dialog now appears when resolving conversation to match the UX of deleting a conversation. (#3671) * DOC-3131: Setting editor height to a pt or em value was ignoring min/max height settings. (#3669) * DOC-3131: The `editor.selection.scrollIntoView()` method now pads the target scroll area with a small margin, ensuring content doesn't sit at the very edge of the viewport. (#3666) * DOC-3131: The editor.selection.scrollIntoView() method now pads the target scroll area with a small margin, ensuring content doesn't sit at the very edge of the viewport. * Update modules/ROOT/pages/7.8.0-release-notes.adoc Co-authored-by: Arvin(Jintao) Han <20640097+ArvinJ-H@users.noreply.github.com> --------- Co-authored-by: Arvin(Jintao) Han <20640097+ArvinJ-H@users.noreply.github.com> * DOC-3131: The change event was not dispatched when deleting a comment reply. (#3670) * DOC-3131: Focus outline was misaligned with comment card border on saving an edit. (#3678) * DOC-3131: Source Code editor was not scrolling to the editor's caret position in Firefox. (#3667) * DOC-3131: Source Code editor was not scrolling to the editor's caret position in Firefox. * Update modules/ROOT/pages/7.8.0-release-notes.adoc Co-authored-by: Karl Kemister-Sheppard <karlkemistersheppard@gmail.com> * Update modules/ROOT/pages/7.8.0-release-notes.adoc Co-authored-by: Karl Kemister-Sheppard <karlkemistersheppard@gmail.com> --------- Co-authored-by: Karl Kemister-Sheppard <karlkemistersheppard@gmail.com> * DOC-11923: Add note on handling of relative URLs with base_url configuration option. (#3682) * DOC-11923: Add note on handling of relative URLs with base_url configuration option. * DOC-3131: add content. * DOC-3131: update title headers. * DOC-3189: Add new options for preserving MathML elements and attributes in the Math plugin (#3681) * DOC-3189: Add new options for preserving MathML elements and attributes in the Math plugin. * Update modules/ROOT/pages/7.8.0-release-notes.adoc * Update modules/ROOT/pages/7.8.0-release-notes.adoc * Update modules/ROOT/pages/7.8.0-release-notes.adoc * Update modules/ROOT/pages/7.8.0-release-notes.adoc * DOC-3161: Add new `tinycomments_fetch_author_info` option and refactored callback demo. (#3675) * DOC-3189: Update comments callback demo DOC-3189: Added tinycomments_fetch_author_info new option Removes Pollyjs from old demo added release notes for TinyMCE 7.8.0 * DOC-3190: Clarify author identification process in comments callback documentation. * Update modules/ROOT/pages/7.8.0-release-notes.adoc Co-authored-by: Hamza Benkhaldoun <hamza0867@gmail.com> * Update modules/ROOT/partials/configuration/tinycomments_fetch_author_info.adoc * Update modules/ROOT/partials/configuration/tinycomments_fetch_author_info.adoc * DOC-3161: Update tinycomments_fetch_author_info documentation to indicate optional fields for authorName and authorAvatar. * Update modules/ROOT/partials/configuration/tinycomments_fetch_author_info.adoc * DOC-3161: Fixed demo * DOC-3161: Updated mentions demo * DOC-3161: fix issue * DOC-3161: Update new option * Potential fix for code scanning alert no. 40: Semicolon insertion Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> * Potential fix for code scanning alert no. 39: Semicolon insertion Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> --------- Co-authored-by: Hamza Benkhaldoun <hamza0867@gmail.com> Co-authored-by: MitchCTiny <mitchell.crompton@tiny.cloud> Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> * DOC-3189: Refactor promotion documentation and update references to new promotions page (#3674) * DOC-3189: Refactor promotion documentation and update references to new promotions page. * DOC-3190: Update promotion documentation to clarify options for open source and cloud versions. * Update modules/ROOT/partials/configuration/onboarding.adoc * Update modules/ROOT/partials/configuration/promotion.adoc * DOC-3131: Fix sidebar nesting issue. * DOC-3131: Keyboard navigation between toolbars no longer loses focus. (#3661) * DOC-3131: Keyboard navigation between toolbars no longer loses focus. * Update modules/ROOT/pages/7.8.0-release-notes.adoc Co-authored-by: CODE:AG <57781325+abhinavgandham@users.noreply.github.com> --------- Co-authored-by: CODE:AG <57781325+abhinavgandham@users.noreply.github.com> * DOC-3131: New subtoolbar support for context toolbars. (#3664) * DOC-3131: Add image filter assets, and new `uploadcare_filters` option for `uploadcare` plugin. (#3679) * DOC-3131: Add image filter assets, and new uploadcare_filters option for Uploadcare plugin. * DOC-3131: update live-demo with new uploadcare_filters option. * DOC-3189: Enhance documentation for uploadcare_filters option in Image Optimizer plugin. * DOC-3131: Copy edits to filter list name. * DOC-3131: Add auto-image-enhancement icon and update documentation, remove old image-enhancements.svg and ref. * DOC-3131: Fix note missing border. * Update antora.yml * DOC-3131: Non-uploadcare image URLs would be altered by color adjustments even when they failed to upload. (#3665) * DOC-3131: Dragging and dropping image files onto the placeholder was not possible if the files had the correct extension but an incorrect MIME type. (#3663) * DOC-3131: Dragging and dropping image files onto the placeholder was not possible if the files had the correct extension but an incorrect MIME type. * Update modules/ROOT/pages/7.8.0-release-notes.adoc * Update modules/ROOT/pages/7.8.0-release-notes.adoc * DOC-3131: Placeholder element is now responsive and adjust to container width. (#3683) Co-authored-by: Karl Kemister-Sheppard <karlkemistersheppard@gmail.com> * DOC-3131: Add changelog. * DOC-3131: It wasn't possible to add comments to selected footnotes elements. (#3662) * DOC-3131: It wasn't possible to add comments to selected footnotes elements. * DOC-3131: Dragging and dropping image files onto the placeholder was not possible if the files had the correct extension but an incorrect MIME type. * Revert "DOC-3131: Dragging and dropping image files onto the placeholder was not possible if the files had the correct extension but an incorrect MIME type." This reverts commit b6a1bd0. * Update modules/ROOT/pages/7.8.0-release-notes.adoc Co-authored-by: ltrouton <46954949+ltrouton@users.noreply.github.com> * Update modules/ROOT/pages/7.8.0-release-notes.adoc Co-authored-by: ltrouton <46954949+ltrouton@users.noreply.github.com> * Update modules/ROOT/pages/7.8.0-release-notes.adoc --------- Co-authored-by: ltrouton <46954949+ltrouton@users.noreply.github.com> * DOC-3131: The tooltip for the `blockquote` button was not translated in Hebrew. (#3684) * DOC-3131: The tooltip for the button was not translated in Hebrew. * DOC-3131: Updated translation entry in 7.7.0 docs under known issues to point to this bug fix entry. --------- Co-authored-by: Karl Kemister-Sheppard <karlkemistersheppard@gmail.com> * DOC-3131: copy edits, release note re-structure and final version checks. * DOC-3131: add missed new line space. * DOC-3131: api-version bump for TinyMCE 7.8.0. * DOC-3131: update productminorversion to 7.8. --------- Co-authored-by: Arvin(Jintao) Han <20640097+ArvinJ-H@users.noreply.github.com> Co-authored-by: CODE:AG <57781325+abhinavgandham@users.noreply.github.com> Co-authored-by: Hamza Benkhaldoun <hamza0867@gmail.com> Co-authored-by: MitchCTiny <mitchell.crompton@tiny.cloud> Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Co-authored-by: ltrouton <46954949+ltrouton@users.noreply.github.com> --------- Co-authored-by: Arvin(Jintao) Han <20640097+ArvinJ-H@users.noreply.github.com> Co-authored-by: CODE:AG <57781325+abhinavgandham@users.noreply.github.com> Co-authored-by: Hamza Benkhaldoun <hamza0867@gmail.com> Co-authored-by: MitchCTiny <mitchell.crompton@tiny.cloud> Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Co-authored-by: ltrouton <46954949+ltrouton@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: DOC-3131
Site: Staging branch
Changes:
Pre-checks:
feature/<version>/,hotfix/<version>/,staging/<version>/, orrelease/<version>/.Review: