Skip to content

DOC-3153: Remove dark mode detection and set skin to oxide-dark in demo examples; update release notes formatting issue. #3639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kemister85 merged 1 commit into from
Mar 6, 2025
Merged

DOC-3153: Remove dark mode detection and set skin to oxide-dark in demo examples; update release notes formatting issue. #3639

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions modules/ROOT/examples/live-demos/full-featured/example.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ const fetchApi = import(
// Instead, an alternate method for retrieving the API key should be used.
const openai_api_key = "<INSERT_OPENAI_API_KEY_HERE>";

const useDarkMode = window.matchMedia('(prefers-color-scheme: dark)').matches;
const isSmallScreen = window.matchMedia('(max-width: 1023.5px)').matches;

tinymce.init({
Expand Down Expand Up @@ -111,8 +110,7 @@ tinymce.init({
content_style: '.mymention{ color: gray; }',
contextmenu: 'link image editimage table configurepermanentpen',
a11y_advanced_options: true,
skin: useDarkMode ? 'oxide-dark' : 'oxide',
content_css: useDarkMode ? 'dark' : 'default',
skin: 'oxide-dark',
autocorrect_capitalize: true,
mergetags_list: [
{
Expand Down
4 changes: 1 addition & 3 deletions modules/ROOT/examples/live-demos/full-featured/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,6 @@ tinymce.ScriptLoader.loadScripts(['https://cdn.jsdelivr.net/npm/faker@5/dist/fak
});
};

const useDarkMode = window.matchMedia('(prefers-color-scheme: dark)').matches;
const isSmallScreen = window.matchMedia('(max-width: 1023.5px)').matches;

const ai_request = (request, respondWith) => {
Expand Down Expand Up @@ -523,8 +522,7 @@ tinymce.ScriptLoader.loadScripts(['https://cdn.jsdelivr.net/npm/faker@5/dist/fak
'body { font-family:Helvetica,Arial,sans-serif; font-size:16px }',
contextmenu: 'link image editimage table spellchecker configurepermanentpen',
a11y_advanced_options: true,
skin: useDarkMode ? 'oxide-dark' : 'oxide',
content_css: useDarkMode ? 'dark' : 'default',
skin: 'oxide-dark',
mentions_selector: '.mymention',
mentions_fetch: mentions_fetch,
mentions_menu_hover: mentions_menu_hover,
Expand Down
2 changes: 1 addition & 1 deletion modules/ROOT/pages/7.7.0-release-notes.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ For information on the **Accessibility Checker** plugin, see: xref:a11ychecker.a

{productname} {release-version} also includes the following improvements:

==== Improved visual indication of keyboard focus for a comment annotation when there is an image inside.
=== Improved visual indication of keyboard focus for a comment annotation when there is an image inside.
// #TINY-11596

In previous versions of **Comments**, annotated non-text elements occasionally displayed a double bottom border when selected, leading to a visual inconsistency that appeared buggy and clashed with existing border styles.
Expand Down
Loading