Skip to content

Comments

[sx126x] Wio sx1262 support#835

Open
HattoriHanzo031 wants to merge 6 commits intotinygo-org:devfrom
HattoriHanzo031:wio_sx1262_support
Open

[sx126x] Wio sx1262 support#835
HattoriHanzo031 wants to merge 6 commits intotinygo-org:devfrom
HattoriHanzo031:wio_sx1262_support

Conversation

@HattoriHanzo031
Copy link
Contributor

@HattoriHanzo031 HattoriHanzo031 commented Jan 11, 2026

No description provided.

@HattoriHanzo031 HattoriHanzo031 changed the base branch from release to dev January 11, 2026 21:59
@HattoriHanzo031 HattoriHanzo031 marked this pull request as draft January 11, 2026 22:45
@HattoriHanzo031 HattoriHanzo031 force-pushed the wio_sx1262_support branch 3 times, most recently from c1be1ad to f6019de Compare January 11, 2026 23:12
@HattoriHanzo031 HattoriHanzo031 marked this pull request as ready for review January 11, 2026 23:12
@deadprogram
Copy link
Member

deadprogram commented Feb 6, 2026

Anything else needed on this PR @HattoriHanzo031 ?

Ignore my IRL questions about the wireless repo migration for the moment.

@HattoriHanzo031
Copy link
Contributor Author

HattoriHanzo031 commented Feb 6, 2026

Anything else needed on this PR @HattoriHanzo031 ?

Ignore my IRL questions about the wireless repo migration for the moment.

I just did one last minute change to use new pin.Output abstraction instead of machine pin.
If everyone is fine with breaking change in New function, I don't have anything more to add.

deadprogram
deadprogram reviewed Feb 14, 2026
View reviewed changes
sx126x/sx126x.go
type Device struct {
spi drivers.SPI // SPI bus for module communication
rstPin machine.Pin // GPIO for reset pin
rstPin pin.Output // GPIO for reset pin
Copy link
Member

@deadprogram deadprogram Feb 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@Escalion
Copy link

Escalion commented Feb 14, 2026

I'll volunteer to test this as I'm working with this hardware right now, but the PR looks good.

@HattoriHanzo031
Copy link
Contributor Author

HattoriHanzo031 commented Feb 15, 2026 •
edited
Loading

I'll volunteer to test this as I'm working with this hardware right now, but the PR looks good.

@Escalion Thank you, this would be very helpful. Please report any bugs or improvements that could be implemented.

P.S. what is the exact hardware you are using (MCU/module combination)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deadprogram deadprogram deadprogram left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@HattoriHanzo031 @deadprogram @Escalion @FilipVranesevic