-
Notifications
You must be signed in to change notification settings - Fork 0
Add merge method to Collectible for lazy concatenation of collections. #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace TinyBlocks\Collection\Internal\Operations\Write; | ||
|
|
||
| use Generator; | ||
| use TinyBlocks\Collection\Internal\Operations\LazyOperation; | ||
|
|
||
| final readonly class Merge implements LazyOperation | ||
| { | ||
| private function __construct(private iterable $otherElements) | ||
| { | ||
| } | ||
|
|
||
| public static function from(iterable $otherElements): Merge | ||
| { | ||
| return new Merge(otherElements: $otherElements); | ||
| } | ||
gustavofreze marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| public function apply(iterable $elements): Generator | ||
| { | ||
| foreach ($elements as $element) { | ||
| yield $element; | ||
| } | ||
|
|
||
| foreach ($this->otherElements as $element) { | ||
| yield $element; | ||
| } | ||
gustavofreze marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
| } | ||
116 changes: 116 additions & 0 deletions
116
tests/Internal/Operations/Write/CollectionMergeOperationTest.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,116 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace Test\TinyBlocks\Collection\Internal\Operations\Write; | ||
|
|
||
| use PHPUnit\Framework\TestCase; | ||
| use TinyBlocks\Collection\Collection; | ||
|
|
||
| final class CollectionMergeOperationTest extends TestCase | ||
| { | ||
| public function testMergeEmptyCollections(): void | ||
| { | ||
| /** @Given two empty collections */ | ||
| $collectionA = Collection::createFromEmpty(); | ||
| $collectionB = Collection::createFromEmpty(); | ||
|
|
||
| /** @When merging the two collections */ | ||
| $actual = $collectionA->merge(other: $collectionB); | ||
|
|
||
| /** @Then the result should be an empty collection */ | ||
| self::assertEmpty($actual->toArray()); | ||
| } | ||
|
|
||
| public function testMergeIntoEmptyCollection(): void | ||
| { | ||
| /** @Given an empty collection and a non-empty collection */ | ||
| $collectionA = Collection::createFromEmpty(); | ||
| $collectionB = Collection::createFrom(elements: [4, 5, 6]); | ||
|
|
||
| /** @When merging the non-empty collection into the empty one */ | ||
| $actual = $collectionA->merge(other: $collectionB); | ||
|
|
||
| /** @Then the result should contain only the elements from the non-empty collection */ | ||
| self::assertSame([4, 5, 6], $actual->toArray()); | ||
| } | ||
|
|
||
| public function testMergeWithEmptyCollection(): void | ||
| { | ||
| /** @Given a non-empty collection and an empty collection */ | ||
| $collectionA = Collection::createFrom(elements: [1, 2, 3]); | ||
| $collectionB = Collection::createFromEmpty(); | ||
|
|
||
| /** @When merging the empty collection into the non-empty one */ | ||
| $actual = $collectionA->merge(other: $collectionB); | ||
|
|
||
| /** @Then the result should contain only the original elements */ | ||
| self::assertSame([1, 2, 3], $actual->toArray()); | ||
| } | ||
|
|
||
| public function testMergeTwoCollections(): void | ||
| { | ||
| /** @Given two collections with distinct elements */ | ||
| $collectionA = Collection::createFrom(elements: [1, 2, 3]); | ||
| $collectionB = Collection::createFrom(elements: [4, 5, 6]); | ||
|
|
||
| /** @When merging collection B into collection A */ | ||
| $actual = $collectionA->merge(other: $collectionB); | ||
|
|
||
| /** @Then the result should contain all elements in order */ | ||
| self::assertSame([1, 2, 3, 4, 5, 6], $actual->toArray()); | ||
| } | ||
|
|
||
| public function testMergePreservesLazyEvaluation(): void | ||
| { | ||
| /** @Given two collections created from generators */ | ||
| $collectionA = Collection::createFrom( | ||
| elements: (static function () { | ||
| yield 1; | ||
| yield 2; | ||
| })() | ||
| ); | ||
|
|
||
| $collectionB = Collection::createFrom( | ||
| elements: (static function () { | ||
| yield 3; | ||
| yield 4; | ||
| })() | ||
gustavofreze marked this conversation as resolved.
Show resolved
Hide resolved
gustavofreze marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| ); | ||
|
|
||
| /** @When merging and retrieving only the first element */ | ||
| $actual = $collectionA->merge(other: $collectionB)->first(); | ||
|
|
||
| /** @Then the first element should be from collection A without materializing all elements */ | ||
| self::assertSame(1, $actual); | ||
gustavofreze marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
|
|
||
| public function testMergeMultipleCollections(): void | ||
| { | ||
| /** @Given three collections */ | ||
| $collectionA = Collection::createFrom(elements: [1, 2]); | ||
| $collectionB = Collection::createFrom(elements: [3, 4]); | ||
| $collectionC = Collection::createFrom(elements: [5, 6]); | ||
|
|
||
| /** @When chaining multiple merge operations */ | ||
| $actual = $collectionA | ||
| ->merge(other: $collectionB) | ||
| ->merge(other: $collectionC); | ||
|
|
||
| /** @Then the result should contain all elements in order */ | ||
| self::assertSame([1, 2, 3, 4, 5, 6], $actual->toArray()); | ||
| } | ||
|
|
||
| public function testMergeWithDuplicateElements(): void | ||
| { | ||
| /** @Given two collections with overlapping elements */ | ||
| $collectionA = Collection::createFrom(elements: [1, 2, 3]); | ||
| $collectionB = Collection::createFrom(elements: [3, 4, 5]); | ||
|
|
||
| /** @When merging the collections */ | ||
| $actual = $collectionA->merge(other: $collectionB); | ||
|
|
||
| /** @Then the result should contain all elements including duplicates */ | ||
| self::assertSame([1, 2, 3, 3, 4, 5], $actual->toArray()); | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.