Skip to content

PCP Plugin Check#109

Open
tijmenbruggeman wants to merge 19 commits into
tinify:masterfrom
wcreateweb:plugin-check
Open

PCP Plugin Check#109
tijmenbruggeman wants to merge 19 commits into
tinify:masterfrom
wcreateweb:plugin-check

Conversation

@tijmenbruggeman
Copy link
Copy Markdown
Collaborator

@tijmenbruggeman tijmenbruggeman commented May 15, 2026

Running PCP will give over 200 violations. Running PHPCS with WordPress Guidelines will give even more. To stay compliant with plug-in guidelines I have increased strictness and also solves some of the issues. More will be incoming.

Changes
Fixed automatically by PHPCS
c1d32ab

Manual Fixes

  • Remove unused parameters
  • change escaped translation string to non-translated escaped string. The strings were not translations.
  • replace sizeof() with count(). sizeof is an alias of count and count is preferred
  • unnecessary string concat. Can simply use a single string.
  • empty catch. Log errors if catch fails
  • underscores for private variables are not necessary
  • move count outside loops
  • use wordpress functions instead of direct php functions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant