Ignore events other than play (fix #168)#209
Merged
thrillfall merged 3 commits intothrillfall:mainfrom Nov 5, 2025
Merged
Conversation
thrillfall
reviewed
Oct 16, 2025
Owner
|
thanks for the contribution |
Xefir
force-pushed
the
168-download-delete-ignored
branch
2 times, most recently
from
2980ef9 to
2ac5bb5
Compare
All events in gPodder are : - play - download - delete - new - flattr (see https://gpoddernet.readthedocs.io/en/latest/api/reference/events.html) `download` and `delete` are ignored by AntennaPod and cause issues with some frontends (see AntennaPod/AntennaPod#6957 (comment)) For `new`, the official documentaion says "This state needs to be interpreted by receiving clients and does not delete any information on the webservice." However, gpodder-sync will erase position and total if client put some value in it (-1 most of the time). It does not respect the spec and should be ignored as well. `flattr` is undocumented and seems unused. By elimination, only play is really helpfull. We should not remove the action column because it can have NEW, DOWNLOAD and DELETE action already with -1 data and could cause damage if removed.
Xefir
force-pushed
the
168-download-delete-ignored
branch
from
2ac5bb5 to
8040c40
Compare
Owner
|
perfect. please add a test for that function. then we can merge right away |
Contributor
Author
|
Done. I choose to edit the existing create action test because it's easier and reflect the reality of the sync done by app like AntennaPod that mix several episodes action in one request. |
Owner
|
awesome. thanks a lot for your contribution. And your patience during vacation time. |
thrillfall
approved these changes
Nov 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All events in gPodder are :
(see https://gpoddernet.readthedocs.io/en/latest/api/reference/events.html)
downloadanddeleteare ignored by AntennaPod and cause issues with some frontends (see AntennaPod/AntennaPod#6957 (comment))For
new, the official documentaion says "This state needs to be interpreted by receiving clients and does not delete any information on the webservice." However, gpodder-sync will erase position and total if client put some value in it (-1 most of the time). It does not respect the spec and should be ignored as well.flattris undocumented and seems unused.By elimination, only play is really helpfull.
We should not remove the action column because it can have NEW, DOWNLOAD and DELETE action already with -1 data and could cause damage if removed.
Linked to #168