feat: add valid log output schemes for http and https #93
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SalmaElsoly
requested review from
Eslam-Nawara,
Omarabdul3ziz,
ashraffouda,
rawdaGastan and
xmonader
as code owners
4 tasks
ashraffouda
approved these changes
Jan 28, 2026
ashraffouda
reviewed
Jan 28, 2026
| "redis": {}, | ||
| "ws": {}, | ||
| "wss": {}, | ||
| "http": {}, |
Collaborator
There was a problem hiding this comment.
what is the reason for supporting http and https?
I think http not the best protocol for sending logs wss or redis is much better/less overhead?
Contributor
Author
There was a problem hiding this comment.
this was meant to support pushing to loki, there is no other way to push logs to Loki over WSS. Even if a service supports WSS, it would still forward logs to Loki over HTTP.
ashraffouda
requested changes
Jan 28, 2026
| "ws": {}, | ||
| "wss": {}, | ||
| "http": {}, | ||
| "https": {}, |
Collaborator
There was a problem hiding this comment.
sending logs over http will put too much load let's check if u can do it with wss or redis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes
Related Issues
threefoldtech/zos#2668
Checklist