Merged
Conversation
ashraffouda
requested review from
Eslam-Nawara,
Omarabdul3ziz,
rawdaGastan and
xmonader
as code owners
Omarabdul3ziz
requested changes
Dec 17, 2025
pkg/container/container.go
Outdated
| log.Debug().Str("ns", ns).Msg("starting container") | ||
| log.Info(). | ||
| Str("namespace", ns). | ||
| Str("data", fmt.Sprintf("%+v", data)). |
Contributor
There was a problem hiding this comment.
data includes envvars, i don't think we should expose that
pkg/vm/manager.go
Outdated
| Uint64("memory-bytes", uint64(vm.Memory)) | ||
|
|
||
| // Log network interfaces with IPs and MACs | ||
| for idx, nic := range nics { |
Contributor
There was a problem hiding this comment.
we can implement a serializer for the interface, to construct a consistent printable string, instead of duplicating in ch.go
Contributor
|
this for sure will help with debugging. also will help if we went with the suggestion to make log level configurable against |
ashraffouda
force-pushed
the
improve-logging
branch
from
842a02b to
411e5c7
Compare
Omarabdul3ziz
approved these changes
Jan 5, 2026
Signed-off-by: Ashraf Fouda <ashraf.m.fouda@gmail.com>
ashraffouda
force-pushed
the
improve-logging
branch
from
411e5c7 to
293b861
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
improve logging in zos
Changes
List of changes this PR includes
Related Issues
threefoldtech/zos#2657
Checklist