[pull] main from modelcontextprotocol:main#246
Merged
pull[bot] merged 3 commits intothreatcode:mainfrom Nov 18, 2025
Merged
Conversation
Updates the Claude Code GitHub Action to use the stable v1 GA release instead of the beta version. ## Changes - Updates action version from `@beta` to `@v1` - Migrates `allowed_tools` to `claude_args: --allowedTools` - Migrates `custom_instructions` to `claude_args: --system-prompt` - Retains `additional_permissions` and `assignee_trigger` (both still supported in v1) ## Behavior The action continues to work the same way: - Triggers on `@claude` mentions in comments, reviews, and issues - Triggers when assigned to an issue as "claude" - Allows Claude to run Bash commands - Allows Claude to read CI results on PRs - Applies custom instructions for posting concise summaries
The 'Check if tests exist' step was actually running tests with continue-on-error: true. If tests failed, it would set has-tests=false and skip the actual test step, making CI appear green even with failing tests. Simplified to use 'npm test --if-present' which: - Runs tests if a test script exists (and fails if tests fail) - Does nothing and exits 0 if no test script exists - Removes the need for the complex check logic Fixes the issue where PR #3014 had failing tests but CI was green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )