Skip to content

[pull] main from modelcontextprotocol:main#246

Merged
pull[bot] merged 3 commits intothreatcode:mainfrom
modelcontextprotocol:main
Nov 18, 2025
Merged

[pull] main from modelcontextprotocol:main#246
pull[bot] merged 3 commits intothreatcode:mainfrom
modelcontextprotocol:main

Conversation

@pull
Copy link

@pull pull bot commented Nov 18, 2025

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.4)

Can you help keep this open source service alive? 💖 Please sponsor : )

merterbak and others added 3 commits November 17, 2025 21:37
Updates the Claude Code GitHub Action to use the stable v1 GA release instead of the beta version.

## Changes
- Updates action version from `@beta` to `@v1`
- Migrates `allowed_tools` to `claude_args: --allowedTools`
- Migrates `custom_instructions` to `claude_args: --system-prompt`
- Retains `additional_permissions` and `assignee_trigger` (both still supported in v1)

## Behavior
The action continues to work the same way:
- Triggers on `@claude` mentions in comments, reviews, and issues
- Triggers when assigned to an issue as "claude"
- Allows Claude to run Bash commands
- Allows Claude to read CI results on PRs
- Applies custom instructions for posting concise summaries
The 'Check if tests exist' step was actually running tests with
continue-on-error: true. If tests failed, it would set has-tests=false
and skip the actual test step, making CI appear green even with failing tests.

Simplified to use 'npm test --if-present' which:
- Runs tests if a test script exists (and fails if tests fail)
- Does nothing and exits 0 if no test script exists
- Removes the need for the complex check logic

Fixes the issue where PR #3014 had failing tests but CI was green.
@pull pull bot locked and limited conversation to collaborators Nov 18, 2025
@pull pull bot added the ⤵️ pull label Nov 18, 2025
@pull pull bot merged commit 28a3132 into threatcode:main Nov 18, 2025
@pull pull bot added the ⤵️ pull label Nov 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants