[pull] master from google:master#26
Merged
pull[bot] merged 3 commits intothreatcode:masterfrom Mar 30, 2026
Merged
Conversation
Signed-off-by: David Korczynski <david@adalogics.com>
This seems necessary for d8 to run from /out/d8
Without this change it results in `Failed to initialize ICU`. Example
failure on solution:
```
$ docker run -it us-docker.pkg.dev/oss-fuzz/tracer/v8:latest /bin/bash
root@85b9ef07d28d:/src/v8# /out/d8
/out/d8: Failed to initialize ICU
root@85b9ef07d28d:/src/v8# cp /src/v8/out/fuzz/icudtl.dat /out/
root@85b9ef07d28d:/src/v8# /out/d8
V8 version 14.8.0 (candidate)
d8>
```
Verified this was the problem by running strace on the failing /out/d8,
and noticing the attempt to `openat`:
```
root@85b9ef07d28d:/src/v8# strace /out/d8
...
mmap(0x7b3f8b3e0000, 262144, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_ANONYMOUS, -1, 0) = 0x7b3f8b3e0000
mmap(0x7b4d8b3e0000, 262144, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_ANONYMOUS, -1, 0) = 0x7b4d8b3e0000
mmap(0x7b2f8b3e0000, 262144, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_ANONYMOUS, -1, 0) = 0x7b2f8b3e0000
mmap(0x7b3d8b3e0000, 262144, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_ANONYMOUS, -1, 0) = 0x7b3d8b3e0000
gettid() = 68
mmap(0x7d4f8b3e0000, 262144, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_ANONYMOUS, -1, 0) = 0x7d4f8b3e0000
mmap(0x7d5d8b3e0000, 262144, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_ANONYMOUS, -1, 0) = 0x7d5d8b3e0000
mmap(0x7b8f8b3e0000, 262144, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_ANONYMOUS, -1, 0) = 0x7b8f8b3e0000
mmap(0x7b9d8b3e0000, 262144, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_ANONYMOUS, -1, 0) = 0x7b9d8b3e0000
rt_sigaction(SIGTERM, {sa_handler=0x56246d0875e0, sa_mask=[], sa_flags=SA_RESTORER, sa_restorer=0x7f0f8c586420}, NULL, 8) = 0
mmap(0x7c5f8b3e0000, 262144, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_ANONYMOUS, -1, 0) = 0x7c5f8b3e0000
mmap(0x7c6d8b3e0000, 262144, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_ANONYMOUS, -1, 0) = 0x7c6d8b3e0000
openat(AT_FDCWD, "/out/icudtl.dat", O_RDONLY) = -1 ENOENT (No such file or directory)
write(2, "/out/d8: Failed to initialize IC"..., 34/out/d8: Failed to initialize ICU
) = 34
mmap(0xac50fb28000, 163840, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_ANONYMOUS|MAP_NORESERVE, -1, 0) = 0xac50fb28000
madvise(0xac50fb28000, 163840, MADV_NOHUGEPAGE) = 0
madvise(0xac50fb28000, 163840, MADV_DONTDUMP) = 0
exit_group(1) = ?
+++ exited with 1 +++
```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )