[pull] master from apify:master#212
Merged
Merged
Conversation
…rkup (#3717) ## What `handleCloudflareChallenge` stopped detecting the Cloudflare challenge. Cloudflare inserted a `.footer-wrapper` element between `.footer-inner` and `.diagnostic-wrapper` on the challenge page, which broke the direct-child detection selector — so the helper returned immediately and the request handler ran against an unsolved "Just a moment..." page (exactly the report in #3629). - Detection now matches by **descendants** (`.footer .footer-inner .diagnostic-wrapper .ray-id`) so intervening wrappers don't break it. - The click position now targets the **actual challenge widget** (the box holding the Turnstile checkbox input), falling back to the old `.main-content div` for older layouts. ## e2e alignment The `camoufox-cloudflare` e2e was also a false green: its own `isBlocked` check used the same broken selector, so the assertion always passed. Fixed that selector, and aligned the browser stack — `camoufox-js@^0.11.0` installs the Camoufox **150** (Firefox 150) build, so the actor now uses **Playwright 1.60** (also Firefox 150). A mismatched Firefox crashes playwright-core on Cloudflare's uncaught page errors (`pageError.location` is undefined), so the versions must line up. Depends on camoufox-js ≥ 0.11.0 (apify/camoufox-js#283). Closes #3629
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )