fix: corrected runtime issue for empty permission strings, closes #3423

phpmyfaq/assets/templates/admin/user/group.twig

@@ -252,7 +252,7 @@
                    name="group_rights[]" value="{{ right.right_id }}"
                    class="form-check-input permission" disabled>
             <label class="form-check-label" for="group_right_{{ right.right_id }}">
-              {{ right.name|permission }}
+              {{ right.name | default('') | permission }}
             </label>
           </div>
           {% endfor %}

phpmyfaq/assets/templates/admin/user/users.twig

@@ -176,7 +176,7 @@
                    name="user_rights[]" value="{{ right.right_id }}"
                    class="form-check-input permission" />
             <label class="form-check-label" for="user_right_{{ right.right_id }}">
-              {{ right.name|default('Unknown')|permission }}
+              {{ right.name | default('') | permission }}
             </label>
           </div>
           {% endfor %}

phpmyfaq/src/phpMyFAQ/Template/Extensions/PermissionTranslationTwigExtension.php

@@ -32,7 +32,6 @@ public function getFilters(): array
 
     private function getPermissionTranslation(string $string): string
     {
-        $translationCode = sprintf('permission::%s', $string);
-        return Translation::get($translationCode) ?? '';
+        return empty($string) ? '' : (Translation::get(sprintf('permission::%s', $string)) ?? '');
     }
 }

tests/phpMyFAQ/Template/Extensions/PermissionTranslationTwigExtensionTest.php

@@ -14,7 +14,7 @@ protected function setUp(): void
         $this->extension = new PermissionTranslationTwigExtension();
     }
 
-    public function testGetFilters()
+    public function testGetFilters(): void
     {
         $filters = $this->extension->getFilters();