Attempt 2: adjust for S7 in ggplot2#430
Merged
thomasp85 merged 1 commit intothomasp85:mainfrom Jun 18, 2025
Merged
Conversation
Collaborator
Author
|
Closing this in favour of more defensive strategies in ggplot2 |
Collaborator
Author
|
I was a bit too optimistic, it turns out these methods are needed for 25 packages. |
Collaborator
Author
|
Failures seem to be due to old R versions or old CI and not necessarily related to this PR. |
Owner
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has the same goal as, and replaces, #429.
This PR simply copies the
ggclass operators for the S7ggplot2::ggclass.