[SDK] Fix null options handling in useFetchWithPayment hook #8540

joaquim-verges · 2025-12-11T10:45:01Z

PR-Codex overview

This PR focuses on improving the handling of options in the useFetchWithPayment hook by ensuring that it defaults to an empty object if options is null or undefined.

Detailed summary

Updated the spread operator for options to use options ?? {} instead of just options, ensuring it defaults to an empty object when options is null or undefined.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

Bug Fixes
- Improved error handling to enhance application stability in edge case scenarios.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

vercel · 2025-12-11T10:45:03Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
docs-v2	Ready	Preview	Comment	Dec 11, 2025 10:57am
nebula	Ready	Preview	Comment	Dec 11, 2025 10:57am
thirdweb_playground	Ready	Preview	Comment	Dec 11, 2025 10:57am
thirdweb-www	Ready	Preview	Comment	Dec 11, 2025 10:57am
wallet-ui	Ready	Preview	Comment	Dec 11, 2025 10:57am

changeset-bot · 2025-12-11T10:45:06Z

⚠️ No Changeset found

Latest commit: 3c356de

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2025-12-11T10:45:08Z

Walkthrough

A single file receives a null-safety improvement to prevent errors when the options parameter is null or undefined. The useMemo now spreads a safe object using the nullish coalescing operator instead of directly spreading potentially null options.

Changes

Cohort / File(s)	Change Summary
Null-safe options handling `packages/thirdweb/src/react/web/hooks/x402/useFetchWithPayment.tsx`	Modified useMemo to spread `...(options ?? {})` instead of `...options`, preventing errors when options is null or undefined while preserving storage default logic

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	The description includes the PR-Codex overview but lacks the required template sections (issue tag, Notes for the reviewer, and How to test) that should be filled in according to the repository's template.	Complete the PR description by adding the Linear issue tag (TEAM-0000 format), explicit reviewer notes, and testing instructions (unit tests, playground details) in the appropriate template sections.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely summarizes the main change: fixing null/undefined options handling in the useFetchWithPayment hook, which aligns directly with the code changes.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch _SDK_Fix_null_options_handling_in_useFetchWithPayment_hook

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between f5ab57f and 3c356de.

📒 Files selected for processing (1)

packages/thirdweb/src/react/web/hooks/x402/useFetchWithPayment.tsx (1 hunks)

🧰 Additional context used

📓 Path-based instructions (4)

**/*.{ts,tsx}

📄 CodeRabbit inference engine (CLAUDE.md)

**/*.{ts,tsx}: Write idiomatic TypeScript with explicit function declarations and return types
Limit each TypeScript file to one stateless, single-responsibility function for clarity
Re-use shared types from @/types or local types.ts barrels
Prefer type aliases over interface except for nominal shapes in TypeScript
Avoid any and unknown in TypeScript unless unavoidable; narrow generics when possible
Choose composition over inheritance; leverage utility types (Partial, Pick, etc.) in TypeScript

**/*.{ts,tsx}: Write idiomatic TypeScript with explicit function declarations and return types
Limit each file to one stateless, single-responsibility function for clarity and testability
Re-use shared types from @/types or local types.ts barrel exports
Prefer type aliases over interface except for nominal shapes
Avoid any and unknown unless unavoidable; narrow generics whenever possible
Choose composition over inheritance; leverage utility types (Partial, Pick, etc.)
Comment only ambiguous logic in TypeScript files; avoid restating TypeScript types and signatures in prose

Files:

packages/thirdweb/src/react/web/hooks/x402/useFetchWithPayment.tsx

packages/thirdweb/src/**/*.{ts,tsx}

📄 CodeRabbit inference engine (CLAUDE.md)

packages/thirdweb/src/**/*.{ts,tsx}: Comment only ambiguous logic in SDK code; avoid restating TypeScript in prose
Load heavy dependencies inside async paths to keep initial bundle lean (e.g. const { jsPDF } = await import("jspdf");)

Lazy-load heavy dependencies inside async paths to keep the initial bundle lean (e.g., const { jsPDF } = await import('jspdf');)

Files:

packages/thirdweb/src/react/web/hooks/x402/useFetchWithPayment.tsx

**/*.{js,jsx,ts,tsx,json}

📄 CodeRabbit inference engine (AGENTS.md)

Biome governs formatting and linting; its rules live in biome.json. Run pnpm fix & pnpm lint before committing, ensure there are no linting errors

Files:

packages/thirdweb/src/react/web/hooks/x402/useFetchWithPayment.tsx

**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (AGENTS.md)

Lazy-import optional features; avoid top-level side-effects

Files:

packages/thirdweb/src/react/web/hooks/x402/useFetchWithPayment.tsx

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)

GitHub Check: E2E Tests (pnpm, vite)
GitHub Check: E2E Tests (pnpm, webpack)
GitHub Check: E2E Tests (pnpm, esbuild)
GitHub Check: Lint Packages
GitHub Check: Build Packages
GitHub Check: Unit Tests
GitHub Check: Size
GitHub Check: Analyze (javascript)

🔇 Additional comments (1)

packages/thirdweb/src/react/web/hooks/x402/useFetchWithPayment.tsx (1)

259-266: Null-safe options spread in resolvedOptions is correct

Using ...(options ?? {}) ensures the hook won't throw when callers pass null or omit options, while preserving existing behavior for defined options (explicit storage still overrides the webLocalStorage default). This is a targeted, backward-compatible fix with no obvious side effects.

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)

TEAM-0000: Entity not found: Issue - Could not find referenced Issue.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

joaquim-verges · 2025-12-11T10:45:17Z

[SDK] Fix null options handling in useFetchWithPayment hook #8540 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

merge-queue - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2025-12-11T10:50:47Z

size-limit report 📦

Path	Size
@thirdweb-dev/nexus (esm)	105.66 KB (0%)
@thirdweb-dev/nexus (cjs)	319.47 KB (0%)

[SDK] Fix null options handling in useFetchWithPayment hook

3c356de

joaquim-verges marked this pull request as ready for review December 11, 2025 10:45

github-actions bot assigned joaquim-verges Dec 11, 2025

joaquim-verges requested review from a team as code owners December 11, 2025 10:45

github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Dec 11, 2025

joaquim-verges merged commit 20e41ee into main Dec 11, 2025
16 of 23 checks passed

joaquim-verges deleted the _SDK_Fix_null_options_handling_in_useFetchWithPayment_hook branch December 11, 2025 10:47

vercel bot deployed to Preview – wallet-ui December 11, 2025 10:47 View deployment

vercel bot deployed to Preview – nebula December 11, 2025 10:48 View deployment

vercel bot deployed to Preview – thirdweb_playground December 11, 2025 10:50 View deployment

vercel bot deployed to Preview – thirdweb-www December 11, 2025 10:54 View deployment

vercel bot deployed to Preview – docs-v2 December 11, 2025 10:57 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[SDK] Fix null options handling in useFetchWithPayment hook #8540

[SDK] Fix null options handling in useFetchWithPayment hook #8540

Uh oh!

joaquim-verges commented Dec 11, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

vercel bot commented Dec 11, 2025 •

edited

Loading

Uh oh!

changeset-bot bot commented Dec 11, 2025

Uh oh!

coderabbitai bot commented Dec 11, 2025 •

edited

Loading

Review ran into problems

Uh oh!

joaquim-verges commented Dec 11, 2025

Uh oh!

Uh oh!

github-actions bot commented Dec 11, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

[SDK] Fix null options handling in useFetchWithPayment hook #8540

[SDK] Fix null options handling in useFetchWithPayment hook #8540

Uh oh!

Conversation

joaquim-verges commented Dec 11, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR-Codex overview

Detailed summary

Summary by CodeRabbit

Uh oh!

vercel bot commented Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Dec 11, 2025

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Pre-merge checks and finishing touches

Review ran into problems

Uh oh!

joaquim-verges commented Dec 11, 2025

How to use the Graphite Merge Queue

Uh oh!

Uh oh!

github-actions bot commented Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

joaquim-verges commented Dec 11, 2025 •

edited by coderabbitai bot

Loading

vercel bot commented Dec 11, 2025 •

edited

Loading

coderabbitai bot commented Dec 11, 2025 •

edited

Loading

github-actions bot commented Dec 11, 2025 •

edited

Loading