Skip to content

Conversation

@d4mr
Copy link
Contributor

@d4mr d4mr commented Jan 9, 2025

PR-Codex overview

This PR updates the checks for sponsored transactions to ensure that the isZkSyncChain function is awaited, improving the accuracy of the validation for these transactions.

Detailed summary

  • In src/worker/tasks/send-transaction-worker.ts, changed the check for isZkSyncChain(chain) to await the promise.
  • In src/shared/utils/transaction/simulate-queued-transaction.ts, similarly updated the check for isZkSyncChain(chain) to await the promise.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@zeet-co
Copy link

zeet-co bot commented Jan 9, 2025

We're building your pull request over on Zeet.
Click me for more info about your build and deployment.
Once built, this branch can be tested at: https://thirdweb-engine-ad8x-pb-fix-zksyn-4170df.engine-aws-usw2.zeet.app before merging 😉

@d4mr d4mr merged commit db40029 into main Jan 10, 2025
6 checks passed
@d4mr d4mr deleted the pb/fix-zksync-async-check branch January 10, 2025 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants