Fix: Direct MQTT publish for fw request#90
Closed
LeoGranierWiifor wants to merge 1 commit intothingsboard:masterfrom
Closed
Fix: Direct MQTT publish for fw request#90LeoGranierWiifor wants to merge 1 commit intothingsboard:masterfrom
LeoGranierWiifor wants to merge 1 commit intothingsboard:masterfrom
Conversation
LeoGranierWiifor
force-pushed
the
fix/get_firmware_direct_publish
branch
from
0dc7a88 to
298ccc8
Compare
Contributor
Author
|
Hello @imbeacon, This pull request is quite important, as it addresses and resolves an exception that occurs when changing the target firmware on the ThingsBoard platform. Could you please review it and let me know whether it's acceptable as-is or if any changes are needed? Thank you in advance, |
…ze and not a json)
LeoGranierWiifor
force-pushed
the
fix/get_firmware_direct_publish
branch
from
298ccc8 to
48dfaf4
Compare
Contributor
|
Everything looks good for me, but could you create a new PR, without force pushes in it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In function
__get_firmware, the function_publish_datais not suitable as payload will be empty ('') or the chunk size ("1024" for example). The functions called by_publish_dataexpects the payload to be a valid JSON.Direct publish is a suitable fix.