Enable FA (future annotations) linting ruleset#2795
Merged
jku merged 2 commits intotheupdateframework:developfrom Feb 19, 2025
Merged
Enable FA (future annotations) linting ruleset#2795jku merged 2 commits intotheupdateframework:developfrom
jku merged 2 commits intotheupdateframework:developfrom
Conversation
Signed-off-by: pakagronglb <pakagronglebel@gmail.com>
Signed-off-by: pakagronglb <pakagronglebel@gmail.com>
25800fa to
acd7ed0
Compare
jku
approved these changes
Feb 19, 2025
Member
jku
left a comment
There was a problem hiding this comment.
LGTM, thanks for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We already use future annotations (
from __future__ import annotations) in most of the codebase. This change enables the FA linting ruleset to ensure consistent usage across all files by:tox -e lintto verify compliancetoxto ensure no regressionsThe linter passes without any FA-related issues, confirming that our codebase already follows the future annotations best practices consistently.
Testing:
tox -e lint- all checks passedtox- all tests passed