Type/annotation fixes#2778
Merged
jku merged 2 commits intotheupdateframework:developfrom Jan 31, 2025
Merged
Conversation
mypy warns about this but we know that encode_canonical() cannot return None if we don't set output_function argument. ruff does not like assert so I added a "noqa" and a comment Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
mypy rightly complains our types do not match (this only happen if you enable type checks for securesystemslib): * I think the annotation is actually wrong: Envelope does not know the contained type at this point. * Likely SimpleEnvelope should not be generic: it does not relly know what it contains I decided not to break the API here and just made the type cast explicit (even though we don't really know that the cast is correct): this silences mypy but has no other consequences. Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
mnm678
approved these changes
Jan 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These annotation issues come up if the type checking is enabled for securesystemslib.
Fixes #2775, makes it possible to potentially enable type checks in next securesystemslib release