Audio: SRC: Fix return code for failed delay lines allocate#10701
Open
singalsu wants to merge 1 commit intothesofproject:mainfrom
Open
Audio: SRC: Fix return code for failed delay lines allocate#10701singalsu wants to merge 1 commit intothesofproject:mainfrom
singalsu wants to merge 1 commit intothesofproject:mainfrom
Conversation
The proper return code is -ENOMEM. The -EINVAL makes this look like at higher logs level a component internal failure that it isn't. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR corrects the error code returned when delay line allocation fails in the SRC module, so failures are reported as an out-of-memory condition rather than an invalid-argument/internal failure.
Changes:
- Change the return code on
cd->delay_linesallocation failure from-EINVALto-ENOMEM.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
abonislawski
approved these changes
Apr 14, 2026
kv2019i
approved these changes
Apr 14, 2026
lyakh
approved these changes
Apr 15, 2026
Collaborator
lyakh
left a comment
lyakh
left a comment
There was a problem hiding this comment.
could've removed an additional space while at it but NM ;-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The proper return code is -ENOMEM. The -EINVAL makes this look like at higher logs level a component internal failure that it isn't.