topology2: add SDW jack and amp compress feature topologies#10651
topology2: add SDW jack and amp compress feature topologies#10651bardliao wants to merge 1 commit into
Conversation
| COMPRESSED=true" | ||
|
|
||
| "cavs-sdw\;sof-sdca-amp-compr\;SDW_JACK=false,NUM_HDMIS=0,COMPRESSED_2=true,\ | ||
| COMPRESSED=true" |
There was a problem hiding this comment.
I would have COMPRESSED=true first, then the COMPRESSED_1/2, but it is a nit only.
There was a problem hiding this comment.
I think for the COMPRESS_2=true you also need COMPRESS_1=false
There was a problem hiding this comment.
I updated in both cases to ensure the other compress is false.
bardliao
force-pushed
the
topology2-compr
branch
from
f40a1fd to
3c5c459
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds two new Topology2 production build targets under the SDCA generic SoundWire set, intended to generate compressed-audio variants for jack and amplifier use cases.
Changes:
- Add
sof-sdca-jack-comprproduction topology target (compressed jack variant). - Add
sof-sdca-amp-comprproduction topology target (compressed amp/speaker variant).
| "cavs-sdw\;sof-sdca-jack-compr\;SDW_JACK=false,NUM_HDMIS=0,COMPRESSED=true,\ | ||
| COMPRESSED_1=true,COMPRESSED_2=false" |
There was a problem hiding this comment.
The feature topologies should work with function topologies. The mixout.1.1 will be created by the sdw jack function topology.
ujfalusi
left a comment
ujfalusi
left a comment
There was a problem hiding this comment.
I have tested these and they work great!
@lgirdwood The feature topology should work with the function topology. But the copilot doesn't know the fact. So, the comments are not valid. |
Thanks Ive resolved, btw there is a conflict. |
add SDW jack and amp compress feature topologies. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Fixed |
add SDW jack and amp compress feature topologies.