Adding customization for "events" processing to Http client#2320
Open
quinnjr wants to merge 1 commit intothe-guild-org:masterfrom
Open
Adding customization for "events" processing to Http client#2320quinnjr wants to merge 1 commit intothe-guild-org:masterfrom
quinnjr wants to merge 1 commit intothe-guild-org:masterfrom
Conversation
🦋 Changeset detectedLatest commit: e48b25c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
quinnjr
force-pushed
the
add-customization-to-http-client
branch
3 times, most recently
from
09baa15 to
b8276d1
Compare
quinnjr
force-pushed
the
add-customization-to-http-client
branch
from
b8276d1 to
e48b25c
Compare
Contributor
Author
|
@kamilkisiela ready for your review when you have a chance |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
was reached (not necessary for small changes)
About
Creating the ability to define in each request on the
contextinput the different kinds of underlying Angular HttpClient options.It is primarily suited to adding support for watching and 'event' of the HttpClient to determine events being emitted by the HttpClient as it processes the request/response.
Had to add the coercion of the FetchResult type to the SubscriptionResult type in
subscription.tsor else Typescript was throwing errors for it.Also includes bumping the versioning for the dev container as the current version doesn't work correctly with the engine version in
package.jsonor the requirements of Angular itself.