doc(queryconfig): Allows configuring a different element query mechanism#964
Open
MatthiasKainer wants to merge 3 commits intotesting-library:mainfrom
Open
doc(queryconfig): Allows configuring a different element query mechanism#964MatthiasKainer wants to merge 3 commits intotesting-library:mainfrom
MatthiasKainer wants to merge 3 commits intotesting-library:mainfrom
Conversation
Provides the ability to specify a different element query mechanism other than querySelector and querySelectorAll.
An example of the usage with Georgegriff/query-selector-shadow-dom looks like this:
import { querySelectorAllDeep, querySelectorDeep } from 'query-selector-shadow-dom';
configure({
queryElement: querySelectorDeep,
queryAllElements: querySelectorAllDeep,
})
After this line, a query will also drill into the shadow dom of elements on the page
Why:
In our project, we are using a design system build with web components
(via stenciljs), and different projects in different frameworks (lit,
react, vue) want to use this library. The corresponding pr can be found
here:
testing-library/dom-testing-library#1054
4 tasks
Member
timdeschryver
left a comment
timdeschryver
left a comment
There was a problem hiding this comment.
I haven' taken a look at the implementation PR, but I left a few remarks on the wording.
Co-authored-by: Tim Deschryver <28659384+timdeschryver@users.noreply.github.com>
Co-authored-by: Tim Deschryver <28659384+timdeschryver@users.noreply.github.com>
timdeschryver
approved these changes
Nov 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provides the ability to specify a different element query mechanism other than querySelector and querySelectorAll.
An example of the usage with Georgegriff/query-selector-shadow-dom looks like this:
After this line, a query will also drill into the shadow dom of elements on the page
Why:
In our project, we are using a design system build with web components
(via stenciljs), and different projects in different frameworks (lit,
react, vue) want to use this library. The corresponding pr can be found
here:
testing-library/dom-testing-library#1054