feat: support shadow-dom-testing-library#1277
feat: support shadow-dom-testing-library#1277Sysix wants to merge 8 commits intotesting-library:mainfrom
shadow-dom-testing-library#1277Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1277 +/- ##
=======================================
Coverage 97.35% 97.36%
=======================================
Files 49 49
Lines 6020 6033 +13
Branches 1544 1545 +1
=======================================
+ Hits 5861 5874 +13
Misses 157 157
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@KonnorRogers would be great to have a quick review from you too ❤️ |
|
@Belco90 I rebased the PR, if the tests are failing again for some node versions, I would like to get a little hint how to resolve it :) |
I'm not entirely sure what's causing the failures, to be honest. I see that |
Signed-off-by: Alexander S. <sysix@sysix-coding.de>
|
It works with node v24.12.0 & eslint 9: I commented out the library for one rule-test, the CI logs shows over 9000 test cases. |
@Sysix it didn't make any difference... This needs further investigation, but can't do it now. Should be easy to reproduce by using the same Node version than in CI. |
Signed-off-by: Alexander S. <sysix@sysix-coding.de>
|
@Belco90 I tested it with different node versions, matching the CI env, and with ESLint v10. I could not identify the problem. My guess is removing the new test-cases will not "overload" to node thread |
Checks
Changes
shadow-dom-testing-libraryto the known modulesgetByShadow*methods toALL_QUERIES_METHODSContext
fixes #1242