fix: resolve gemspec load path and refactor proxy config method #440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change File.expand_path to use __dir__ instead of __FILE__ in gemspec to properly resolve the lib directory path - Extract repetitive proxy environment variable logic into separate proxy_env_vars helper method - Reduce dockerfile_proxy_config ABC size from 24.21 to below threshold - Reduce method length from 14 lines to 4 lines to meet style guidelines Signed-off-by: Dan Webb <dan.webb@damacus.io>
Signed-off-by: Dan Webb <dan.webb@damacus.io>
Contributor
Author
|
@copilot look at how we do things in https://github.com/test-kitchen/kitchen-vagrant/ fix this chefstyle issue |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dan Webb dan.webb@damacus.io