fix: Avoids issue due to strict requirement for fileexists to return consistent results #722
+3
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
lorengordon
force-pushed
the
fix/build-pkg-only
branch
from
b1c6785 to
03b0dea
Compare
lorengordon
changed the title
In old versions of terraform, the ternary operator did not short-circuit, and so the `was_missing` logic was a hack to workaround both paths executing on every execution. The module needed the hack to avoid failing When the package existed previously vs when it did not and was being created by the module itself. In recent-ish version of terraform, including the module min version 1.5.7, the ternary operator will shortcircuit, so it will only execute the true OR false logic, rather than both. This makes the `was_missing` logic unnecessary. Further, in most recent versions of terraform, at least since 1.13.0, the `was_missing` logic resulted in a failure when separately building the package and then attempting to use the package in the same workflow. The failure occurred because terraform became more strict at enforcing that the return values of the `fileexists()` function be consistent between plan and apply phases. Fixes terraform-aws-modules#698
lorengordon
force-pushed
the
fix/build-pkg-only
branch
from
03b0dea to
bfcda3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In old versions of terraform, the ternary operator did not short-circuit, and so the
was_missinglogic was needed as a hack to workaround both logic paths executing on every run. The module needed the hack to avoid failing when the package existed previously vs when it did not and was being created by the module itself.In recent-ish versions of terraform, including the module min version 1.5.7, the ternary operator will shortcircuit, so it will only execute the true OR false logic, rather than both. This makes the
was_missinglogic unnecessary.Further, in most recent versions of terraform, at least since 1.13.0, the
was_missinglogic resulted in a failure when separately building the package and then attempting to use the package in the same workflow. The failure occurred because terraform became more strict at enforcing that the return values of thefileexists()function be consistent between plan and apply phases.Fixes #698
Breaking Changes
None
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request