Add support for TensorFlow 2.18#984
Open
psamanoelton wants to merge 1 commit intotensorflow:masterfrom
Open
Conversation
mhucka
approved these changes
Feb 5, 2026
Member
mhucka
left a comment
There was a problem hiding this comment.
Really fantastic to see NumPy 2 and Cirq 1.5 compatibility. I just have one question, about the Eigen commit change. Otherwise LGTM.
Comment on lines
58
to
+60
| # This commit corresponds to Eigen version 3.4.90 | ||
| # (verified via Eigen/src/Core/util/Macros.h). | ||
| EIGEN_COMMIT = "c1d637433e3b3f9012b226c2c9125c494b470ae6" | ||
| EIGEN_COMMIT = "33d0937c6bdf5ec999939fb17f2a553183d14a74" |
Member
There was a problem hiding this comment.
The commit hash is changed, but the comment still refers to version 3.4.90. Does this commit still correspond to 3.4.90?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
requirements.inand usepip-compileto producerequirements.txtKey changes
@org_tensorflowto 2.18.1requirements.in:requirements.txtis produced by runningpip-compile --upgrade --generate-hashes -o requirements.txt requirements.intensorflow_quantum/python/differentiators/linear_combination.py:np.mathto.mathand importingmathto properly handle numpy 2.0.2Testing
bazel build ... release:build_pip_packagesucceedsscripts/test_all.sh&./scripts/ci_validate_tutorials.sh) passNotes