Cirq 1.5.x to Cirq 1.6.1#1078
Open
psamanoelton wants to merge 5 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request drops support for Python 3.10, raising the minimum supported version to Python 3.11, and updates various dependencies including Cirq to 1.6.1 and NumPy to 2.1. Feedback on the changes points out that while Python 3.13 is explicitly unsupported, the version checks in configure.sh and release/build_pip_package.sh only enforce a lower bound of >= 3.11. It is recommended to add an upper bound check of < 3.13 to prevent build or installation failures on newer Python versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates TensorFlow Quantum to support the current Cirq release line while preserving Python 3.10 support.
The resulting support matrix is:
This keeps TFQ compatible with TensorFlow 2.19.1 across Python 3.10-3.12 while still moving newer Python versions onto the current Cirq release line.
What changed
cirq-core==1.5.0/cirq-google==1.5.0for Python<3.11cirq-core==1.6.1/cirq-google==1.6.1for Python>=3.11release/setup.pymetadata to support Python>=3.10,<3.13configure.shandrelease/build_pip_package.shto allow Python 3.10, 3.11, and 3.12requirements_lock_3_10.txtrequirements_lock_3_11.txtrequirements_lock_3_12.txtWhy this approach
Cirq 1.6.x requires Python 3.11 or newer, but TensorFlow 2.19.1 still supports Python 3.10.
Instead of dropping Python 3.10 entirely, this PR keeps support by splitting the dependency track:
This preserves compatibility for existing Python 3.10 users while still allowing newer supported Python versions to use the current Cirq release line.
Python support after this PR
Python 3.13 is still excluded because TensorFlow 2.19.1 does not publish Python 3.13 wheels.
Validation
Validated successfully with local Docker-based workflows for:
Validation included:
Notes
configure.shstill defaults to CPU automaticallyrequirements.txtremains the primary dev lock, and version-specific lockfiles are used for Python-specific validation/build flows