Add unit tests for TFQPauliSumCollector.collect#1015
Open
mhucka wants to merge 3 commits intotensorflow:masterfrom
Open
Add unit tests for TFQPauliSumCollector.collect#1015mhucka wants to merge 3 commits intotensorflow:masterfrom
mhucka wants to merge 3 commits intotensorflow:masterfrom
Conversation
This change implements unit tests for the `collect` method in `TFQPauliSumCollector`, addressing a testing gap in `batch_util_test.py`. The new tests cover: - Standard Pauli Z observable (expected energy -1.0) - Identity observable (expected energy 1.0) - Mixed observable (Z + 2.0*I) (expected energy 1.0) This improves the reliability and coverage of the batch utility module.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds unit tests for the collect method of TFQPauliSumCollector, which is a good addition to improve test coverage. The tests cover several important cases, including Z, Identity, and mixed observables. My feedback includes a suggestion to refactor the test to improve its structure and maintainability, making it more concise and easier to extend in the future.
Good suggestion from Gemini Code Assist. Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change implements unit tests for the
collectmethod inTFQPauliSumCollector, addressing a testing gap inbatch_util_test.py. The new tests cover: