Improve missing optional dependency error#1989
Open
jonas-eschle wants to merge 2 commits intotensorflow:mainfrom
Open
Improve missing optional dependency error#1989jonas-eschle wants to merge 2 commits intotensorflow:mainfrom
jonas-eschle wants to merge 2 commits intotensorflow:mainfrom
Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes to improve the error message when an optional dependency is missing
ImportErrororModuleNotFoundError, but flexible), therefore not breaking any code. This allows to add a clear message and instruction. The previousprintwas printing before the stacktrace, obfuscating the actual instructions. Now they are prominently displayed.tf-kerasfor conda-forge, as we intend to make it an optional dependency there as well and conda does not offer the same optional dependencies as pypi does.