Tenant aware tinker should define tenant interface#168
Open
fabricecw wants to merge 1 commit intotenancy:masterfrom
Open
Tenant aware tinker should define tenant interface#168fabricecw wants to merge 1 commit intotenancy:masterfrom
fabricecw wants to merge 1 commit intotenancy:masterfrom
Conversation
Instead of defining the connection, we should also define the `Hyn\Tenancy\Contracts\Tenant` interface. This ensures that retrieving the current website via `app(\Hyn\Tenancy\Environment::class)->tenant();` as suggested in the docs is possible.
Member
|
I know these are some old docs and I know we don't recommemd setting the tenant whenever cause it changes a lot in the application so not sure on this. Calling backup: @bkintanar |
Author
|
Thanks for your feedback. But isn't it exactly what we expect when running "tinker on a tenant website"? Looking forward for @bkintanar's view. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of defining the connection, we should also define the
Hyn\Tenancy\Contracts\Tenantinterface.This ensures that retrieving the current website via
app(\Hyn\Tenancy\Environment::class)->tenant();as suggested in the docs is possible.