feat: swap fees immediately and remove executeBlock system transaction post AllegroModerato #1448
+505
−73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgimenez
requested review from
0xKitsune,
klkvr,
mattsse and
rakita
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
bot
added
A-evm
fgimenez
force-pushed
the
fgimenez/remove-feeamm-system-tx
branch
from
6dc9846 to
3021702
Compare
fgimenez
force-pushed
the
fgimenez/remove-feeamm-system-tx
branch
from
0e8f7b6 to
48d7cf3
Compare
Collaborator
|
Closing with preference for #1537, most of the changes are carried over with small fixes/changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1439
Implements immediate fee swaps during transaction execution, replacing the batched end-of-block approach.
collectFeePreTxnow executes swaps immediately viaexecuteFeeSwapand accumulates fees directlycollectFeePostTxcall (no refunds - users pay max fee upfront)executeBlocksystem transactiondistributeFees(validator)for validators to claim accumulated fees on-demand