Merged
Conversation
yux0
reviewed
Mar 30, 2026
| isHandoverNamespace := ns.IsGlobalNamespace() && | ||
| ns.ActiveInCluster(s.GetClusterMetadata().GetCurrentClusterName()) && | ||
| ns.ReplicationState() == enumspb.REPLICATION_STATE_HANDOVER | ||
| ns.ReplicationState("") == enumspb.REPLICATION_STATE_HANDOVER |
Contributor
There was a problem hiding this comment.
are we special handling the empty value?
yux0
approved these changes
Mar 31, 2026
yycptt
reviewed
Apr 3, 2026
| isHandoverNamespace := ns.IsGlobalNamespace() && | ||
| ns.ActiveInCluster(s.GetClusterMetadata().GetCurrentClusterName()) && | ||
| ns.ReplicationState() == enumspb.REPLICATION_STATE_HANDOVER | ||
| ns.ReplicationState("") == enumspb.REPLICATION_STATE_HANDOVER |
| oldNS.Name() != newNS.Name() || | ||
| oldNS.IsGlobalNamespace() != newNS.IsGlobalNamespace() || | ||
| oldNS.ActiveInCluster(r.currentClusterName) != newNS.ActiveInCluster(r.currentClusterName) || | ||
| oldNS.ReplicationState("") != newNS.ReplicationState("") |
Member
There was a problem hiding this comment.
hmm if different businessID can have different replication state, checking the state of only one businessID won't be enough? Or maybe there's something special about the "" businessID?
yycptt
approved these changes
Apr 3, 2026
| oldNS.Name() != newNS.Name() || | ||
| oldNS.IsGlobalNamespace() != newNS.IsGlobalNamespace() || | ||
| oldNS.ActiveInCluster(r.currentClusterName) != newNS.ActiveInCluster(r.currentClusterName) || | ||
| oldNS.ReplicationState("") != newNS.ReplicationState("") |
bergundy
approved these changes
Apr 6, 2026
Member
bergundy
left a comment
bergundy
left a comment
There was a problem hiding this comment.
Approved but please add the comment I requested.
| } | ||
|
|
||
| if err := c.namespaceValidationInterceptor.ValidateState(c.namespace, c.apiName); err != nil { | ||
| if err := c.namespaceValidationInterceptor.ValidateState(c.namespace, c.apiName, ""); err != nil { |
Member
There was a problem hiding this comment.
Suggested change
| if err := c.namespaceValidationInterceptor.ValidateState(c.namespace, c.apiName, ""); err != nil { | |
| // Nexus requests are not tied to a business ID, hence the empty string. | |
| if err := c.namespaceValidationInterceptor.ValidateState(c.namespace, c.apiName, ""); err != nil { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Modifying replication state to optionally take wfid + fixing ns state change to use activeInCluster
Why?
adherence to interface goals
How did you test it?