Skip to content

[Worker-Versioning improvement]: Activate "Drained/Inactive" versions #9147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
Shivs11 wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

[Worker-Versioning improvement]: Activate "Drained/Inactive" versions #9147

Shivs11 wants to merge 11 commits into from

Conversation

@Shivs11
Copy link
Member

@Shivs11 Shivs11 commented Jan 27, 2026 •
edited
Loading

What changed?

  • activate drained/inactive versions to draining when they get a workflow started on it
  • also added a history cache, per history node, so that we don't bombard our version workflows with signals that shall change the drainage status of these workflows.

Why?

  • versioning correctness, in the sense that if someone were to move a workflow on to a version that is drained, the drainage status should be updated to draining (since it now has one open workflow working on it)

How did you test it?

  • built
  • run locally and tested manually
  • covered by existing tests
  • added new unit test(s)
  • added new functional test(s)

Potential risks

  • Sure, this change is lowkey risky. Would appreciate a thorough review.

Shivs11
Shivs11 commented Jan 27, 2026
View reviewed changes
common/worker_versioning/worker_versioning.go

// GenerateDeploymentWorkflowID is a helper that generates a system accepted
// workflowID which are used in our Worker Deployment workflows
func GenerateDeploymentWorkflowID(deploymentName string) string {
Copy link
Member Author

@Shivs11 Shivs11 Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just minor refactoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Shivs11