Skip to content

Move proto check and test to separate job #1412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jmaeagle99 wants to merge 3 commits into
base: main
Choose a base branch
from
+35 −22
Open

Move proto check and test to separate job #1412

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d90fe6a
Move proto check and test to separate job
jmaeagle99 Apr 4, 2026
58ab13d
Merge branch 'main' into separate-proto-check
tconley1428 Apr 6, 2026
d373849
Merge branch 'main' into separate-proto-check
jmaeagle99 Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 35 additions & 22 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,6 @@ jobs:
docsTarget: true
openaiTestTarget: true
clippyLinter: true
- os: ubuntu-latest
python: "3.10"
protoCheckTarget: true
- python: "3.10"
pytestExtraArgs: "--reruns 3 --only-rerun \"RuntimeError: Failed validating workflow\""
- os: ubuntu-arm
Expand Down Expand Up @@ -85,25 +82,6 @@ jobs:
path: junit-xml
retention-days: 14

# Confirm protos are already generated properly with older protobuf
# library and run test with that older version. We must downgrade protobuf
# so we can generate 3.x and 4.x compatible API. We have to use older
# Python to run this check because the grpcio-tools version we use
# is <= 3.10.
- name: Check generated protos and test protobuf 3.x
if: ${{ matrix.protoCheckTarget }}
env:
TEMPORAL_TEST_PROTO3: 1
run: |
uv remove google-adk --optional google-adk
uv add --python 3.10 "protobuf<4"
uv sync --all-extras
poe build-develop
poe gen-protos
[[ -z $(git status --porcelain temporalio) ]] || (git diff temporalio; echo "Protos changed"; exit 1)
poe test -s --ignore=tests/contrib/google_adk_agents/
timeout-minutes: 10

# Do docs stuff (only on one host)
- name: Build API docs
if: ${{ matrix.docsTarget }}
Expand All @@ -122,6 +100,41 @@ jobs:
run: |
npx doctoc README.md
[[ -z $(git status --porcelain README.md) ]] || (git diff README.md; echo "README changed"; exit 1)

check-protos:
timeout-minutes: 30
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
submodules: recursive
- uses: dtolnay/rust-toolchain@stable
- uses: Swatinem/rust-cache@v2
with:
workspaces: temporalio/bridge -> target
- uses: actions/setup-python@v5
with:
python-version: "3.10"
- uses: arduino/setup-protoc@v3
with:
# TODO(cretz): Can upgrade proto when https://github.com/arduino/setup-protoc/issues/99 fixed
version: "23.x"
repo-token: ${{ secrets.GITHUB_TOKEN }}
- uses: astral-sh/setup-uv@v5
- run: uv tool install poethepoet
- run: uv remove google-adk --optional google-adk
- run: uv add --python 3.10 "protobuf<4"
- run: uv sync --all-extras
- run: poe build-develop
- run: poe gen-protos
- name: Check generation unchanged
run: |
[[ -z $(git status --porcelain temporalio) ]] || (git diff temporalio; echo "Protos changed"; exit 1)
- name: Test with protobuf 3.x
run: poe test -s --ignore=tests/contrib/google_adk_agents/
env:
TEMPORAL_TEST_PROTO3: 1

test-latest-deps:
timeout-minutes: 30
runs-on: ubuntu-latest
Expand Down