Skip to content

Conversation

@picatz
Copy link
Contributor

@picatz picatz commented Oct 27, 2025

Summary

  • .github/workflows/ci.yml: Added a workflow-level GITHUB_TOKEN permissions block restricting access to contents: read for least-privilege coverage across all jobs.

This change was made by an automated process to ensure all GitHub Actions workflows have explicitly defined permissions as per best practices.
@picatz picatz requested a review from a team as a code owner October 27, 2025 16:57
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cretz
Copy link
Member

cretz commented Oct 27, 2025

@picatz - This has shown that one of our tests connects to the public internet improperly. We will fix (see #63), but I wonder why it only showed up on macos and not ubuntu? I assume the former does some writing the latter doesn't?

EDIT: Actually, this appears unrelated to this PR and is just a side-effect of us having not run these tests in two weeks. We will fix CI alongside #63.

@picatz
Copy link
Contributor Author

picatz commented Oct 27, 2025

@cretz thank you for the review! Looks like I don't have the ability to merge this PR, can you click the button for me? 😄

@cretz
Copy link
Member

cretz commented Oct 27, 2025

CI is failing which we have configured to prevent merge. I was hoping that we could get #63 solved, but it could be a couple of weeks, so I'll go ahead and bypass CI checks for this PR and merge.

@cretz cretz merged commit 5f8b574 into main Oct 27, 2025
7 of 11 checks passed
@cretz cretz deleted the security-campaign/set-explicit-github-actions-permissions branch October 27, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants