-
Notifications
You must be signed in to change notification settings - Fork 6
Add OpenTelemetry Sample #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1cde36a to
3119beb
Compare
cretz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor request to change the module name of all files (sorry my branch was invalid on this point)
| ) | ||
| ) | ||
| ) | ||
| tracer = OpenTelemetry.tracer_provider.tracer('opentelemetry_sample_test', '1.0.0') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note, there's also a way to set an in-memory exporter here somehow if you wanted to assert traces, but not that important
3119beb to
0743b12
Compare
cretz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor README change needed, then all good
Co-authored-by: Chad Retz <chad@temporal.io>
What was changed
Added OpenTelemetry sample.
Primarily copied over @cretz's work from https://github.com/cretz/temporal-samples-ruby/tree/opentelemetry with some small tweaks.
Checklist
Closes Sample request: OpenTelemetry #10
How was this tested:
Followed Readme instructions and added automatic test.