Skip to content

Conversation

@chris-olszewski
Copy link
Member

What was changed

Added OpenTelemetry sample.

Primarily copied over @cretz's work from https://github.com/cretz/temporal-samples-ruby/tree/opentelemetry with some small tweaks.

Checklist

  1. Closes Sample request: OpenTelemetry #10

  2. How was this tested:
    Followed Readme instructions and added automatic test.

@chris-olszewski chris-olszewski force-pushed the olszewski/open_telemetry branch from 1cde36a to 3119beb Compare October 13, 2025 16:28
@chris-olszewski chris-olszewski marked this pull request as ready for review October 13, 2025 16:31
@chris-olszewski chris-olszewski requested a review from a team as a code owner October 13, 2025 16:31
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor request to change the module name of all files (sorry my branch was invalid on this point)

)
)
)
tracer = OpenTelemetry.tracer_provider.tracer('opentelemetry_sample_test', '1.0.0')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note, there's also a way to set an in-memory exporter here somehow if you wanted to assert traces, but not that important

@chris-olszewski chris-olszewski force-pushed the olszewski/open_telemetry branch from 3119beb to 0743b12 Compare October 14, 2025 13:35
@chris-olszewski chris-olszewski requested a review from cretz October 14, 2025 13:37
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor README change needed, then all good

Co-authored-by: Chad Retz <chad@temporal.io>
@chris-olszewski chris-olszewski merged commit 5eaa7c5 into main Oct 14, 2025
7 checks passed
@chris-olszewski chris-olszewski deleted the olszewski/open_telemetry branch October 14, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sample request: OpenTelemetry

3 participants