chore: upgrade temporal SDK to v1.41.0 and envconfig to v1.0.0#975
Open
chaptersix wants to merge 1 commit intotemporalio:mainfrom
Open
chore: upgrade temporal SDK to v1.41.0 and envconfig to v1.0.0#975chaptersix wants to merge 1 commit intotemporalio:mainfrom
chaptersix wants to merge 1 commit intotemporalio:mainfrom
Conversation
- Fixes TLS disabled handling: envconfig v1.0.0 now sets ConnectionOptions.TLSDisabled = true when profile TLS is disabled, resolving the bug where --api-key X --tls=false would still dial with TLS enabled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
go.temporal.io/sdkfrom v1.38.0 to v1.41.0 in both root andcliextmodulesgo.temporal.io/sdk/contrib/envconfigfrom v0.1.0 to v1.0.0 in both modulesWhy
envconfig v0.1.0 had a bug where
ToClientOptionsdid not setConnectionOptions.TLSDisabled = truewhen a profile had TLS disabled. This meant that passing--api-key X --tls=falsewould still dial with TLS enabled (because the SDK auto-enables TLS when credentials are present), overriding the user's explicit--tls=falseflag.Fixed upstream in temporalio/sdk-go#2205, released in envconfig v1.0.0.