Fix activity command flag bugs and help text inconsistencies#974
Merged
Fix activity command flag bugs and help text inconsistencies#974
Conversation
yiminc
approved these changes
Apr 6, 2026
| RunId: c.RunId, | ||
| }, | ||
| Identity: c.Parent.Identity, | ||
| Identity: c.Identity, |
Member
There was a problem hiding this comment.
if c.Identity is empty, will it fallback to the default one?
Contributor
Author
There was a problem hiding this comment.
Updated to fallback to the default one
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
--identityflag, always sending the global client identity instead of the per-command one--reasonflag despite the server-sidePauseActivityRequestaccepting one--activity-typeshowedactivity-idas its value placeholder in pause, unpause, and reset help output--reset-heartbeatson unpause and reset incorrectly claimed it only works with--reset-attempts-ashorthand for--activity-idthat the other activity subcommands already hadWhy?
These were found during an internal bug bash as either bugs or inconsistencies.
Checklist