Fix pypi workflow on private repos, fix alembic migration check#27
Merged
Fix pypi workflow on private repos, fix alembic migration check#27
Conversation
…check to use temp DB - pypi workflow only had id-token:write; declaring any permissions key drops all others to none, so checkout failed with 'repository not found' on private repos. Added contents:read to restore checkout access. - check_ungenerated_migrations ran alembic check against whatever database DATABASE_URL pointed to. In CI there is no pre-existing database, so alembic reported 'Target database is not up to date' before comparing models to migrations at all. Updated the target to create a fresh temp DB, run upgrade head, then check, then clean up — matching the create_migration pattern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pypi workflow only had id-token:write; declaring any permissions key drops all others to none, so checkout failed with 'repository not found' on private repos. Added contents:read to restore checkout access.
check_ungenerated_migrations ran alembic check against whatever database DATABASE_URL pointed to. With some use cases there may be problems with the database in CI that results in alembic reporting 'Target database is not up to date'. Updated the target to create a fresh temp DB, run upgrade head, then check, then clean up — matching the create_migration pattern.