Conversation
Implement TimeStamping feature tecnickcom#617
|
Why did you open this PR since #617 is open? |
|
Hi William,
I thought it was easier to restart from the latest TCPDF version.
That is the commit, with Hidaw improvements, I have tested.
|
|
Oh okay, I can force push your work to the original PR then |
|
Do whatever you need. |
|
Please consider adding this feature to the new https://github.com/tecnickcom/tc-lib-pdf library instead. |
|
Lib-tc-pdf is too much change at this time for a lot of dev, your new library is too different and would need to remake all the PDF files. TCPDF is not close to be deprecated as your lib-tc-pdf is far from being equivalent. |
I think one way forward is a major version of tcpdf that would be based on the new library. As a wrapper of the new library. Allowing users to keep code compatibility. |
|
Be realists guys, except if your days are not as full as ours, this won't be available before months, probably years. |
Signature max length changed
Extracerts array or filename
Private key password integration
Extracerts
|
Okay so I understand you won't merge any commit to TCPDF anymore ? |
|
Keep this PR nice and clean, the less lines changed in TCPDF main the better. Use PHPStan to get your code clean etc.. |
Implement TimeStamping feature
#617