Conversation
WalkthroughUpdates project dependencies to support Sphinx 9 by loosening the sphinx-design version constraint from an exact pin to a flexible range. Also includes changelog documentation and removes minor formatting inconsistencies. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #170 +/- ##
=======================================
Coverage 94.78% 94.78%
=======================================
Files 10 10
Lines 594 594
=======================================
Hits 563 563
Misses 31 31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The RTD build run using Sphinx v9.1.0 and myst v5.0.0 is hitting two kinds of warnings, one from Python and one from Sphinx / docutils. -- https://app.readthedocs.org/projects/sphinx-design-elements/builds/31079757/#302672396--14 -- https://app.readthedocs.org/projects/sphinx-design-elements/builds/31079757/#302672396--50 NB: I am just documenting the hiccup diligently so that others in the same or a similar boat can find related problems when updating to Sphinx 9, and hopefully find a solution right away within this PR. |
|
The second warning was mitigated with 685f0ce. 🪂 |
... effectively enabling support for Sphinx 9.
WARNING: Transition must be child of <document> or <section>. [docutils]
| `hyper-navigate`, `hyper-open`, `hyper-tutorial`, `hyper-read-more`, | ||
| `hyper-readme-github`, `hyper-nb-colab`, `hyper-nb-binder`, `hyper-nb-github`. | ||
|
|
||
| --- | ||
|
|
||
| {hyper-navigate}`https://example.org` | ||
| {hyper-open}`https://example.org` |
There was a problem hiding this comment.
That spot raised this Sphinx warning, effectively failing the build because we are using -W --keep-going across the board?
WARNING: Transition must be child of <document> or <section>. [docutils]
About
Make the package support Sphinx 9 by permitting installation of sphinx-design 0.7.0. Thank you, @chrisjsewell!
References