refactor(dialog): reuse message command for confirm#3287
refactor(dialog): reuse message command for confirm#3287Legend-Master merged 6 commits intotauri-apps:v2from
message command for confirm#3287Conversation
Package Changes Through ff8954aThere are 6 changes which include fs with minor, fs-js with minor, http with patch, http-js with patch, dialog with minor, dialog-js with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
message command for confirmmessage command for confirm
amrbashir
left a comment
There was a problem hiding this comment.
this is breaking because if users are not using dialog:default or don't have dialog:allow-message permission
if a breaking change is desired, then I'd suggest updating the change log to reflect that.
Otherwise, I'd suggest keeping allow-ask, allow-confirm and include allow-message as a nested command for them, as we did in fs plugin
|
Nice catch! Never thought about that possibility. Changed the confirm and ask permissions to be aliases of message permissions |
No description provided.