Skip to content

refactor(dialog): reuse message command for confirm#3287

Merged
Legend-Master merged 6 commits intotauri-apps:v2from
Legend-Master:re-use-message-dialog-command
Mar 1, 2026
Merged

refactor(dialog): reuse message command for confirm#3287
Legend-Master merged 6 commits intotauri-apps:v2from
Legend-Master:re-use-message-dialog-command

Conversation

@Legend-Master
Copy link
Copy Markdown
Contributor

No description provided.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 28, 2026

Package Changes Through ff8954a

There are 6 changes which include fs with minor, fs-js with minor, http with patch, http-js with patch, dialog with minor, dialog-js with minor

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
api-example 2.0.41 2.0.42
api-example-js 2.0.37 2.0.38
fs 2.4.5 2.5.0
fs-js 2.4.5 2.5.0
dialog 2.6.0 2.7.0
dialog-js 2.6.0 2.7.0
http 2.5.7 2.5.8
http-js 2.5.7 2.5.8
persisted-scope 2.3.5 2.3.6

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@Legend-Master Legend-Master changed the title chore(dialog): reuse message command for confirm refactor(dialog): reuse message command for confirm Feb 28, 2026
@Legend-Master Legend-Master marked this pull request as ready for review February 28, 2026 07:36
@Legend-Master Legend-Master requested a review from a team as a code owner February 28, 2026 07:36
Copy link
Copy Markdown
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is breaking because if users are not using dialog:default or don't have dialog:allow-message permission

if a breaking change is desired, then I'd suggest updating the change log to reflect that.

Otherwise, I'd suggest keeping allow-ask, allow-confirm and include allow-message as a nested command for them, as we did in fs plugin

@Legend-Master
Copy link
Copy Markdown
Contributor Author

Legend-Master commented Feb 28, 2026

Nice catch! Never thought about that possibility. Changed the confirm and ask permissions to be aliases of message permissions

Copy link
Copy Markdown
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's clever, LGTM now

@Legend-Master Legend-Master merged commit 2415447 into tauri-apps:v2 Mar 1, 2026
19 checks passed
@Legend-Master Legend-Master deleted the re-use-message-dialog-command branch March 1, 2026 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants