fix: [deep-link] ChromeOS deep link calls filtered and ignored by plugin (fix #3207)#3214
fix: [deep-link] ChromeOS deep link calls filtered and ignored by plugin (fix #3207)#3214joshIsCoding wants to merge 6 commits intotauri-apps:v2from
Conversation
|
Resolved. |
| <!-- ChromeOS ARC++ uses a different action for deep links --> | ||
| <action android:name="org.chromium.arc.intent.action.VIEW" /> |
There was a problem hiding this comment.
is this really needed? facebook/react-native#20301 sounds like it isn't for some reason. afaik multiple actions in a single intent-filter is fine but just to be sure.
There was a problem hiding this comment.
Yeah this was warranted to avoid essentially the same issue, though it potentially depends on how dependent apps apply the intent filters
|
|
||
| companion object { | ||
| var instance: DeepLinkPlugin? = null | ||
| private const val CHROMEOS_ACTION_VIEW = "org.chromium.arc.intent.action.VIEW" |
There was a problem hiding this comment.
i try to avoid using the companion object (dunno why but i always read opinions to avoid it 🤷 )
can the const not be moved outside of the class declaration? If not i wouldn't mind hardcoding it in isViewIntent directly since it's only used there anyway.
|
thanks for the PR! we'll also need a small changefiles (check the .changes folder) :) |
Package Changes Through 6585450There are 12 changes which include sql with minor, sql-js with minor, deep-link with patch, fs with minor, fs-js with minor, http with patch, http-js with patch, updater with patch, updater-js with patch, dialog with minor, dialog-js with minor, deep-link-js with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
|
@FabianLars please forgive the extended delay to my engagement with your feedback - work priorities took over, and we made do with my local fork to unblock our deep-link development. All requested changes are now present; please let me know if you have any further requirements |
2 participants
ChromeOS with ARC uses a different intent view action which is presently excluded by the tauri deep-link plugin. This PR explicitly checks for and includes this variation. I've verified the behaviour resolves deep-link functionality in an Android application of my own deployed to a Chromebook via the Playstore.
Intended to resolve #3207