Skip to content

fix(load-task): consider -hg and -git suffixes in run-task check #861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahal merged 1 commit into from
Nov 6, 2025
Merged

fix(load-task): consider -hg and -git suffixes in run-task check #861

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions src/taskgraph/docker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
)

logger = logging.getLogger(__name__)
RUN_TASK_RE = re.compile(r"run-task(-(git|hg))?$")


def get_image_digest(image_name: str) -> str:
Expand Down Expand Up @@ -418,6 +419,11 @@ def _resolve_image(image: Union[str, dict[str, str]], graph_config: GraphConfig)
return load_image_by_task_id(image_task_id)


def _is_run_task(task_def: dict[str, str]):
cmd = task_def["payload"].get("command") # type: ignore
return cmd and re.search(RUN_TASK_RE, cmd[0])


def load_task(
graph_config: GraphConfig,
task: Union[str, dict[str, Any]],
Expand Down Expand Up @@ -465,9 +471,9 @@ def load_task(

return 1

task_command = task_def["payload"].get("command") # type: ignore
if interactive and (not task_command or not task_command[0].endswith("run-task")):
logger.error("Only tasks using `run-task` are supported with interactive!")
is_run_task = _is_run_task(task_def)
if interactive and not is_run_task:
logger.error("Only tasks using `run-task` are supported with --interactive!")
return 1

try:
Expand All @@ -477,6 +483,7 @@ def load_task(
logger.exception(e)
return 1

task_command = task_def["payload"].get("command") # type: ignore
exec_command = task_cwd = None
if interactive:
# Remove the payload section of the task's command. This way run-task will
Expand Down
Loading