fix infinite loop in cached_tasks transforms #859
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcristau
force-pushed
the
loop
branch
5 times, most recently
from
2eddb4c to
d99bd1e
Compare
Eijebong
approved these changes
Nov 6, 2025
Contributor
Eijebong
left a comment
Eijebong
left a comment
There was a problem hiding this comment.
Just one nit about visit_postorder's doc, rest looks correct to me. And we get rid of one slow handrolled graph traversal algorithm (probably doesn't matter in this case) and we get cycle detection in all graph traversals out of it.
Avoid silently returning a subset of nodes.
Eijebong
reviewed
Nov 6, 2025
Detect dependency cycles instead of looping forever, by using taskgraph.graph.Graph instead of a custom graph traversal. Update the graphs in the tests to not have multiple tasks with the same label, as that breaks uniqueness assumptions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detect dependency cycle instead of looping forever.