Skip to content

fix: make 'run-task' support Python 3.8 again #851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahal merged 1 commit into from
Oct 31, 2025
Merged

fix: make 'run-task' support Python 3.8 again #851

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,13 @@ repos:
hooks:
- id: conventional-pre-commit
stages: [commit-msg]
# TODO remove 'fetch-content' once Gecko no longer needs to use it with Python 3.8
# TODO remove 'fetch-content' and 'run-task' once Gecko no longer needs to use
# them with Python 3.8:
# https://bugzilla.mozilla.org/show_bug.cgi?id=1990567#c7
exclude: |
(?x)^(
src/taskgraph/run-task/fetch-content |
src/taskgraph/run-task/robustcheckout.py |
src/taskgraph/run-task/run-task |
taskcluster/scripts/external_tools
)
4 changes: 2 additions & 2 deletions src/taskgraph/run-task/run-task
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ import time
import urllib.error
import urllib.request
from pathlib import Path
from typing import Optional
from typing import Dict, Optional

SECRET_BASEURL_TPL = "{}/secrets/v1/secret/{{}}".format(
os.environ.get("TASKCLUSTER_PROXY_URL", "http://taskcluster").rstrip("/")
Expand Down Expand Up @@ -573,7 +573,7 @@ def git_fetch(
remote: str = "origin",
tags: bool = False,
shallow: bool = False,
env: Optional[dict[str, str]] = None,
env: Optional[Dict[str, str]] = None,
Copy link
Contributor

@hneiva hneiva Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ugh, the oddities of python indecisiveness

):
args = ["git", "fetch"]
if tags:
Expand Down
Loading