fix: support windows in run-task
#850
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eijebong
approved these changes
Oct 30, 2025
Contributor
Eijebong
left a comment
Eijebong
left a comment
There was a problem hiding this comment.
LGTM, ruff isn't pleased with this though, you'll have to annotate these to appease it.
Taskgraph's version of `run-task` does not currently support Windows. After some investigation, it looks like much of https://bugzilla.mozilla.org/show_bug.cgi?id=1459737 was already ported to it - the only thing that we need to change is to relocate the POSIX-specific imports into a POSIX-specific function.
bhearsum
force-pushed
the
push-optvyxppkvor
branch
from
f451e75 to
e05dc99
Compare
bhearsum
added a commit
to bhearsum/taskgraph
that referenced
this pull request
Oct 31, 2025
Taskgraph's version of `run-task` does not currently support Windows. After some investigation, it looks like much of https://bugzilla.mozilla.org/show_bug.cgi?id=1459737 was already ported to it - the only thing that we need to change is to relocate the POSIX-specific imports into a POSIX-specific function.
abhishekmadan30
pushed a commit
to abhishekmadan30/taskgraph
that referenced
this pull request
Dec 24, 2025
Taskgraph's version of `run-task` does not currently support Windows. After some investigation, it looks like much of https://bugzilla.mozilla.org/show_bug.cgi?id=1459737 was already ported to it - the only thing that we need to change is to relocate the POSIX-specific imports into a POSIX-specific function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taskgraph's version of
run-taskdoes not currently support Windows. After some investigation, it looks like much of https://bugzilla.mozilla.org/show_bug.cgi?id=1459737 was already ported to it - the only thing that we need to change is to relocate the POSIX-specific imports into a POSIX-specific function.